Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable search suggestions by default (uplift to 1.70.x) #25421

Merged
merged 4 commits into from
Sep 6, 2024
Merged

Enable search suggestions by default (uplift to 1.70.x) #25421

merged 4 commits into from
Sep 6, 2024

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Sep 4, 2024 •
edited by kjozwiak
Loading

Uplift of #25161
Uplift of #25099
Uplift of #25118
Uplift of #25243
fix brave/brave-browser#29517
fix brave/brave-browser#40413
fix brave/brave-browser#40415
fix brave/brave-browser#40414

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner September 4, 2024 01:04
@brave-builds brave-builds added this to the 1.70.x - Beta milestone Sep 4, 2024
@brave-builds brave-builds self-assigned this Sep 4, 2024
@simonhong
Merge pull request #25099 from brave/rename_to_show_search_suggestions
afb095d 
Renamed to `Show search suggestions` in search engine settings
@simonhong
Merge pull request #25118 from brave/prevent_search_suggestions_from_…
dc26f0d 
…clipboard

Prevent search suggestions from clipboard text
@simonhong
Merge pull request #25243 from brave/prevent_search_suggestions_for_s…
bb870e7 
…uspicious_query

Improve query check before sending to search suggestions server
LaurenWags
LaurenWags approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@LaurenWags LaurenWags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift to 1.70.x is approved 👍🏻 QA has verified the PR on 1.71.x/Nightly as per:

@kjozwiak kjozwiak merged commit ccdcbd7 into 1.70.x Sep 6, 2024
14 of 15 checks passed
@kjozwiak kjozwiak deleted the pr25161_enable_search_suggestions_1.70.x branch September 6, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaurenWags LaurenWags LaurenWags approved these changes

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.70.x - Release
Development

Successfully merging this pull request may close these issues.
4 participants
@brave-builds @LaurenWags @kjozwiak @simonhong