Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] - Fix Leo yearly subscription ID on nightly (1.73.x) #26520

Merged
merged 1 commit into from
Nov 19, 2024
Merged

[iOS] - Fix Leo yearly subscription ID on nightly (1.73.x) #26520

merged 1 commit into from
Nov 19, 2024

Conversation

Brandon-T
Copy link
Contributor

@Brandon-T Brandon-T commented Nov 12, 2024 •
edited by kjozwiak
Loading

Uplift of #26268
Resolves brave/brave-browser#41931

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@Brandon-T Brandon-T added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-teamcity Do not run builds in TeamCity labels Nov 12, 2024
@Brandon-T Brandon-T self-assigned this Nov 12, 2024
@Brandon-T Brandon-T requested a review from a team as a code owner November 12, 2024 23:53
@kjozwiak kjozwiak mentioned this pull request Nov 13, 2024
Closed
5 tasks
@kjozwiak kjozwiak added this to the 1.73.x - Release #2 milestone Nov 19, 2024
kjozwiak
kjozwiak approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.73.x approved 👍 QA has verified the PR on Nightly using 1.75.x as per #26268 (comment).

@Brandon-T Brandon-T force-pushed the bugfix/ios-leo-yearly-sub-id-1.73.x branch from 2eead43 to 5002407 Compare November 19, 2024 03:40
@Brandon-T Brandon-T force-pushed the bugfix/ios-leo-yearly-sub-id-1.73.x branch from 5002407 to caa0283 Compare November 19, 2024 07:50
@Brandon-T Brandon-T merged commit 1cd111d into 1.73.x Nov 19, 2024
15 checks passed
@Brandon-T Brandon-T deleted the bugfix/ios-leo-yearly-sub-id-1.73.x branch November 19, 2024 16:31
@brave-builds
Copy link
Collaborator

Released in v1.73.91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@Brandon-T Brandon-T

Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-teamcity Do not run builds in TeamCity CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
Milestone
1.73.x - Release #2
Development

Successfully merging this pull request may close these issues.
3 participants
@Brandon-T @brave-builds @kjozwiak