Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds new on boarding flow (uplift to 0.69.x) #3153

Merged
merged 1 commit into from
Aug 13, 2019
Merged

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Aug 12, 2019

Uplift of #3081

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@NejcZdovc NejcZdovc added this to the 0.69.x - Dev milestone Aug 12, 2019
@NejcZdovc NejcZdovc requested a review from a team August 12, 2019 16:55
@NejcZdovc NejcZdovc self-assigned this Aug 12, 2019
@kjozwiak kjozwiak mentioned this pull request Aug 13, 2019
32 tasks
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 0.69.x approved after deliberating with @brave/uplift-approvers. Looks like both CI/Travis and CI/Jenkins have passed. Also went through #3081 (comment) and ensured that the PR is working as expected.

Please make sure that the correct labels are added and the associated issue is moved into the correct milestone.

@NejcZdovc NejcZdovc merged commit f8b4cd5 into 0.69.x Aug 13, 2019
@NejcZdovc NejcZdovc deleted the new-verify-69 branch August 13, 2019 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants