Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds new on boarding flow #3081

Merged
merged 1 commit into from
Aug 7, 2019
Merged

Adds new on boarding flow #3081

merged 1 commit into from
Aug 7, 2019

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Aug 2, 2019 •
edited
Loading

Resolves brave/brave-browser#5518

UI PR: brave/brave-ui#522

Submitter Checklist:

Test Plan:

  • enable rewards
  • open panel and click on verify wallet button
  • make sure that new tab is opened with verify modal shown
  • close that modal
  • click on verify wallet button on rewards page
  • make sure that modal is opened again
  • click on verify
  • make sure that uphold page is opened

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc added this to the 0.70.x - Nightly milestone Aug 2, 2019
@NejcZdovc NejcZdovc self-assigned this Aug 2, 2019
@NejcZdovc NejcZdovc mentioned this pull request Aug 6, 2019
Merged
9 tasks
@NejcZdovc NejcZdovc requested review from tmancey, ryanml and emerick and removed request for ryanml and tmancey August 6, 2019 22:29
@NejcZdovc NejcZdovc marked this pull request as ready for review August 6, 2019 22:29
tmancey
tmancey previously requested changes Aug 6, 2019
View reviewed changes
Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments as Copy is inconsistent

components/resources/brave_components_strings.grd
<message name="IDS_BRAVE_UI_WALLET_VERIFICATION_TITLE2" desc="">And manage your funds easily!</message>
<message name="IDS_BRAVE_UI_WALLET_VERIFICATION_LIST1" desc="">Withdraw BAT that you earn from viewing privacy-respecting ads</message>
<message name="IDS_BRAVE_UI_WALLET_VERIFICATION_LIST2" desc="">Purchase additional BAT with credit cards and other sources</message>
<message name="IDS_BRAVE_UI_WALLET_VERIFICATION_LIST3" desc="">Withdraw BAT that you may have previously added to your Brave Rewards wallet</message>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy in other PR had a full-stop

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image in the issue don't have it brave/brave-browser#5518

emerick
emerick previously approved these changes Aug 6, 2019
View reviewed changes
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

emerick
emerick approved these changes Aug 7, 2019
View reviewed changes
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NejcZdovc NejcZdovc dismissed tmancey’s stale review August 7, 2019 15:55

same as image provided by design

@NejcZdovc NejcZdovc merged commit c678086 into master Aug 7, 2019
@NejcZdovc NejcZdovc deleted the new-verify branch August 7, 2019 15:56
@NejcZdovc NejcZdovc mentioned this pull request Aug 12, 2019
Merged
4 tasks
@kjozwiak
Copy link
Member

Went through the following test cases to ensure the PR was working before approving #3153:

  • ensured that the new modal is being displayed whenever clicking on the following buttons/properties under brave://rewards/
    • Verify Wallet
    • Add Funds
    • Withdraw Funds
    • (verify) <-- next to the `Brave wallet is powered by Uphold
  • ensured that pressing "X" closes the modal without any issues
  • ensured that clicking on Verify Wallet opens uphold.com in the same tab
  • ensured that once you press Verify Wallet within the modal, it doesn't get displayed for the second time
  • Downloaded 0.70.42 CR: 76.0.3809.87, clicked on Verify Wallet on the old UI under brave://rewards/ and updated to 0.70.57 CR: 76.0.3809.100 and ensured the new modal isn't being displayed when clicking on the following:
    • Verify Wallet
    • Add Funds
    • Withdraw Funds
    • (verify) <-- next to the `Brave wallet is powered by Uphold

@GeetaSarvadnya GeetaSarvadnya mentioned this pull request Aug 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emerick emerick emerick approved these changes

@ryanml ryanml Awaiting requested review from ryanml

@tmancey tmancey Awaiting requested review from tmancey

Assignees

@NejcZdovc NejcZdovc

Labels
dependency/brave-ui feature/rewards
Projects
None yet
Milestone
0.69.x - Release
Development

Successfully merging this pull request may close these issues.

New on boarding for wallet verification
4 participants
@NejcZdovc @kjozwiak @tmancey @emerick