Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

Splash verify modal #522

Merged
merged 3 commits into from
Aug 7, 2019
Merged

Splash verify modal #522

merged 3 commits into from
Aug 7, 2019

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Aug 2, 2019 •
edited
Loading

Part of brave/brave-core#3081

Changes

Test plan

Link / storybook path to visual changes

Integration

  • Does this contain changes to src/components or src/

    • Will you publish to npm immediately after this PR, or wait until sometime in the future?
    • Incompatible API change to something existing (major version increase)
    • Adding new backwards-compatible functionality? (minor version increase)
    • Fixing a bug backwards-compatibly? (patch version increase)

  • Does this contain changes to src/features for brave-core?

    • Are there non backwards-compatible changes required for brave-core? Do not merge until brave-core PR is approvable. Link to brave-core PR:
    • Will you create brave-core PR to update to this commit after it is merged?
    • Wants uplift to brave-core feature branch?
      • When uplift-approved, merge to brave-core-0.VV.x feature branch
      • Create additional brave-core PRs for each feature branch to update commit

@NejcZdovc NejcZdovc self-assigned this Aug 2, 2019
@NejcZdovc NejcZdovc changed the title Splash verify Splash verify modal Aug 2, 2019
@NejcZdovc NejcZdovc mentioned this pull request Aug 6, 2019
Merged
32 tasks
@NejcZdovc NejcZdovc requested a review from tmancey August 6, 2019 22:32
tmancey
tmancey approved these changes Aug 6, 2019
View reviewed changes
Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

emerick
emerick approved these changes Aug 6, 2019
View reviewed changes
Copy link
Collaborator

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NejcZdovc NejcZdovc merged commit 568a279 into master Aug 7, 2019
@NejcZdovc NejcZdovc deleted the splash-verify branch August 7, 2019 12:14
NejcZdovc added a commit that referenced this pull request Aug 12, 2019
@NejcZdovc
Merge pull request #522 from brave/splash-verify
58a5f6a 
Splash verify modal
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tmancey tmancey tmancey approved these changes

@emerick emerick emerick approved these changes

@ryanml ryanml Awaiting requested review from ryanml

Assignees

@NejcZdovc NejcZdovc

Labels
rewards
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NejcZdovc @tmancey @emerick