Left sig right sig match failure

[jhoneycutt]

Submitter Checklist:

Resolves brave/brave-browser#6545

• Submitted a ticket for my issue if one did not already exist.
• Used Github auto-closing keywords in the commit message.
• Added/updated tests for this change (for new code or code which already has tests).
• Verified that these changes build without errors on
  • Android
  • iOS
  • Linux
  • macOS
  • Windows
• Verified that these changes pass automated tests (unit, browser, security tests) on
  • iOS
  • Linux
  • macOS
  • Windows
• Verified that all lint errors/warnings are resolved (npm run lint)
• Ran git rebase master (if needed).
• Ran git rebase -i to squash commits (if needed).
• Tagged reviewers and labelled the pull request as needed.
• Request a security/privacy review as needed.
• Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone
• Public documentation has been updated as necessary. For instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protection-Mode
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Custom-Headers
  • https://github.com/brave/brave-browser/wiki/Web-compatibility-issues-with-tracking-protection
  • https://github.com/brave/brave-browser/wiki/QA-Guide

Test Plan:

1. Launch with --enable-logging=stderr --vmodule=*rewards*=6 --rewards=staging=true,reconcile-interval=10,short-retries=true to see log messages, use staging env, set short contribution interval, and short retry interval.
2. Recover wallet with 30 BAT
3. Set AC amount to Up to 20 BAT
4. Add verified and non verified publishers to AC table
5. Add verified recurring tips in this order (5, 10, 10, 10, 1)
6. Wait for monthly contribution to trigger
7. You should see 26 BAT goes through for monthly and 4 BAT from AC
8. Watch terminal and verify that no "Left sig != right sig" error messages appear.
9. Verify that all BAT was delivered to appropriate recipients.

Reviewer Checklist:

• New files have MPL-2.0 license header.
• Request a security/privacy review as needed.
• Adequate test coverage exists to prevent regressions
• Verify test plan is specified in PR before merging to source

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on.
• All relevant documentation has been updated.

[tmancey]

LGTM++

[jhoneycutt]

CI shows several unrelated test failures. However, those failures cause the browser tests to abort early, meaning that the relevant browser tests to this PR are unable to run. The network audit step also fails for unrelated reasons.

[NejcZdovc]

ledger_state is corrupted.

STR:

• claim grant
• do 5 BAT tips to verified publisher one after another
• open ledger_state
• transactions are created for 3 contributions that I did, but data in empty

"auto_contribute": true,
  "transactions": [
    {
      "viewingId": "",
      "surveyorId": "",
      "rates": {},
      "contribution_probi": "",
      "submissionStamp": "",
      "anonizeViewingId": "",
      "registrarVK": "",
      "masterUserToken": "",
      "surveyorIds": [],
      "votes": 0,
      "ballots": []
    },
    {
      "viewingId": "",
      "surveyorId": "",
      "rates": {},
      "contribution_probi": "",
      "submissionStamp": "",
      "anonizeViewingId": "",
      "registrarVK": "",
      "masterUserToken": "",
      "surveyorIds": [],
      "votes": 0,
      "ballots": []
    },
    {
      "viewingId": "",
      "surveyorId": "",
      "rates": {},
      "contribution_probi": "",
      "submissionStamp": "",
      "anonizeViewingId": "",
      "registrarVK": "",
      "masterUserToken": "",
      "surveyorIds": [],
      "votes": 0,
      "ballots": []
    }
  ],

found that transactions being deleted after restart is problem on master as well

[jhoneycutt]

Failing CI steps are npm run audit_deps which are unrelated to this PR.

[bsclifton]

Updated milestone to be 0.74.x 😄 (since that is what master is, when this was merged)