Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Left sig right sig match failure (uplift to 0.72.x) #3895

Merged
merged 1 commit into from
Nov 8, 2019
Merged

Left sig right sig match failure (uplift to 0.72.x) #3895

merged 1 commit into from
Nov 8, 2019

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Nov 6, 2019 •
edited by bsclifton
Loading

Uplift of #3819
Fixes brave/brave-browser#6545

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds self-assigned this Nov 6, 2019
@brave-builds brave-builds added this to the 0.72.x - Beta milestone Nov 6, 2019
@bsclifton bsclifton requested review from a team and removed request for bbondy, kjozwiak, bsclifton, rebron, NejcZdovc and srirambv November 6, 2019 20:27
@mihaiplesa mihaiplesa added CI/skip-android Do not run CI builds for Android CI/skip-linux labels Nov 8, 2019
@mihaiplesa
Copy link
Collaborator

Has passed for Android, Linux, Windows so applied skip labels and will need to be re-built only on iOS and macOS (unless no new changes pushed).

bsclifton
bsclifton approved these changes Nov 8, 2019
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton merged commit 5c0d881 into 0.72.x Nov 8, 2019
@bsclifton bsclifton deleted the pr3819_issue-6545-left-sig-right-sig-match-failure_0.72.x branch November 8, 2019 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsclifton bsclifton bsclifton approved these changes

Assignees

@brave-builds brave-builds

Labels
CI/skip-android Do not run CI builds for Android
Projects
None yet
Milestone
1.1.x - Release
Development

Successfully merging this pull request may close these issues.
4 participants
@brave-builds @mihaiplesa @bsclifton @brave-browser-releases