Restore other bookmarks

[darkdh]

fix brave/brave-browser#7639

Submitter Checklist:

• Submitted a ticket for my issue if one did not already exist.
• Used Github auto-closing keywords in the commit message.
• Added/updated tests for this change (for new code or code which already has tests).
• Verified that these changes build without errors on
  • Android
  • iOS
  • Linux
  • macOS
  • Windows
• Verified that these changes pass automated tests (unit, browser, security tests) on
  • iOS
  • Linux
  • macOS
  • Windows
• Verified that all lint errors/warnings are resolved (npm run lint)
• Ran git rebase master (if needed).
• Ran git rebase -i to squash commits (if needed).
• Tagged reviewers and labelled the pull request as needed.
• Request a security/privacy review as needed.
• Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone
• Public documentation has been updated as necessary. For instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protection-Mode
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Custom-Headers
  • https://github.com/brave/brave-browser/wiki/Web-compatibility-issues-with-tracking-protection
  • https://github.com/brave/brave-browser/wiki/QA-Guide

Test Plan:

Migrate previous migration (if the previous migration folder is still there)

 1. In order to emulate double upgrade, create a folder named "Other Bookmarks" at the end of bookmarks bar, put some bookmarks or folder into it (using old Brave)
 2. Launch Brave with this fix
 3. We should see those bookmarks in "Other Bookmarks" permanent node
 4. Repeat step 1 in current Brave
 5. Manually created "Other Bookmarks" should still be there because migration should only run once

Virtual "Other Bookmarks" mapping

Create

 1. Go to `about:flag#brave-sync` and enable sync on desktop A and desktop B
 2. Sync desktop A, desktop B and then sync mobile C
 3. Wait until each device has 3 devices on its device list
 4. Add `folder A` in "Other Bookmarks" permanent node on desktop A
 5. Desktop B should have `folder A` appears in “Other Bookmarks” permanent node
 6. Mobile C should have `folder A` appears in “Other Bookmarks” folder
 7. Add `folder B` after `folder A` on mobile C
 8. Desktop A and desktop B should have `folder B` after `folder A`

Delete

1. Follow test case “Create”
2. Delete “Other Bookmarks”  folder on mobile C
3. Desktop A and B should have empty “Other Bookmarks” 

Move

1. Follow test case “Create”
2. Add a `folder C` in “Bookmarks on mobile C and wait for it to appear on desktop A & B
3. Move  “Other Bookmarks” folder in `folder C` on mobile C
4. Desktop A & B will have all children of "Other Bookmarks" moved to a same name folder under folder C
5. Add `folder D` on desktop A in "Other Bookmarks" permanent node
6. mobile C should have new "Other Bookmarks" folder created with `folder D` in it

Reorder

1. Follow test case “Create”
2. Add a `folder C` in “Bookmarks on mobile C and wait for it to appear on desktop A & B
3. Move  “Other Bookmarks” folder in front of `folder C`
4. Desktop A & B will have bookmarks in "Other Bookmarks" permanent node stay intact

Rename (iOS doesn’t send rename update)

1. Follow test case “Create”
2. Rename “Other Bookmarks”  folder on mobile C
4. Desktop A & B will have all children of "Other Bookmarks" moved to a renamed folder
5. Add `folder D` on desktop A in "Other Bookmarks" permanent node
6. mobile C should have new "Other Bookmarks" folder created with `folder D` in it

Late joined desktop (1)

1. Go to `about:flag#brave-sync` and enable sync on desktop A 
2. Sync desktop A and mobile C
3. Add `A1.com` in “Other Bookmarks” on desktop A and wait for it to appear in “Other Bookmarks” on mobile C
4. Add `folder C` in “Bookmarks on mobile C  and wait for it to appear on desktop A
5. Move  “Other Bookmarks” folder in `folder C` on mobile C
6. Desktop A will have `A1.com` in “Other Bookmarks” folder in `folder C`
7. Add `A2.com` in “Other Bookmarks” on desktop A and wait for it to appear in “Other Bookmarks” on mobile C
8. Make desktop B  joining sync chain
9. After joining sync chain, add `B1.com` in "Other Bookmarks" permanent node
10. mobile C should have one “Other Bookmarks” with `A2.com` and `B1.com` in it
11. desktop A should have `A2.com` and `B1.com` in its “Other Bookmarks” permanent node

Late joined desktop (2)

1. Go to `about:flag#brave-sync` and enable sync on desktop A 
2. Sync desktop A and mobile C
3. Add `A1.com` in “Other Bookmarks” on desktop A and wait for it to appear in “Other Bookmarks” on mobile C
4. Add `folder C` in “Bookmarks on mobile C  and wait for it to appear on desktop A
5. Move  “Other Bookmarks” folder in `folder C` on mobile C
6. Desktop A will have `A1.com` in “Other Bookmarks” folder in `folder C`
7. Add `A2.com` in “Other Bookmarks” on desktop A and wait for it to appear in “Other Bookmarks” on mobile C
8. Add `B1.com` in "Other Bookmarks" permanent node before joining the sync chain
9. mobile C should have one “Other Bookmarks” with `A2.com` and `B1.com` in it
10. desktop A should have `A2.com` and `B1.com` in its “Other Bookmarks” permanent node

Reviewer Checklist:

• New files have MPL-2.0 license header.
• Request a security/privacy review as needed.
• Adequate test coverage exists to prevent regressions
• Verify test plan is specified in PR before merging to source

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on.
• All relevant documentation has been updated.

[AlexeyBarabash]

++

[darkdh]

only CI failure is

13:48:56  1 test timed out:
13:48:56      BraveRewardsBrowserTest.RecurringTipForVerifiedPublisher (../../brave/components/brave_rewards/browser/rewards_service_browsertest.cc:2366

which is not related to this PR
https://ci.brave.com/job/brave-browser-build-pr/job/restore-other-bookmarks/8//flowGraphTable/?auto_refresh=false