Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds 25 BAT limit for uphold (uplift to 1.12.x) #6049

Merged
merged 1 commit into from
Jul 22, 2020
Merged

Adds 25 BAT limit for uphold (uplift to 1.12.x) #6049

merged 1 commit into from
Jul 22, 2020

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Jul 9, 2020 •
edited by LaurenWags
Loading

Uplift of #5986
Resolves brave/brave-browser#9723

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from NejcZdovc as a code owner July 9, 2020 11:06
@brave-builds brave-builds requested a review from a team July 9, 2020 11:06
@brave-builds brave-builds self-assigned this Jul 9, 2020
@brave-builds brave-builds added this to the 1.12.x - Beta milestone Jul 9, 2020
@NejcZdovc NejcZdovc removed their request for review July 9, 2020 11:09
@kjozwiak
Copy link
Member

kjozwiak commented Jul 9, 2020

QA will need to run through this on Nightly before uplifting as per the process. We'll get to this one once 1.11.x goes out as that's priority right now. CCing @LaurenWags @rebron @mandar-brave @NejcZdovc.

@kjozwiak
Copy link
Member

kjozwiak commented Jul 9, 2020

Looks like test-install failed on macOS as per https://ci.brave.com/job/pr-brave-browser-pr5986_uphold-flow-25_1.12.x/1/execution/node/619/log/. However, this is a known intermittent issue and doesn't block uplift. As per #6049 (comment), this will need a verification on Nightly before uplifting.

LaurenWags
LaurenWags approved these changes Jul 22, 2020
View reviewed changes
Copy link
Member

@LaurenWags LaurenWags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.12.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #5986 (comment).

@LaurenWags LaurenWags merged commit 04a05a0 into 1.12.x Jul 22, 2020
@LaurenWags LaurenWags deleted the pr5986_uphold-flow-25_1.12.x branch July 22, 2020 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaurenWags LaurenWags LaurenWags approved these changes

Assignees

@brave-builds brave-builds

Labels
feature/rewards
Projects
None yet
Milestone
1.12.x - Release #1
Development

Successfully merging this pull request may close these issues.
5 participants
@brave-builds @kjozwiak @LaurenWags @NejcZdovc @brave-browser-releases