-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Desktop] User wallets not permitted up to a threshold of BAT earner #9723
Comments
Upgraded to a P1. Logic: Expected UI change is in the Verify Wallet flow; for users under 25 BAT we need to allow an existing user who does not see the Verify Wallet message to Login. needs discussion @jenn-rhim My suggestion is; keep the existing flows. If Client finds user has less than 25 BAT, we use the existing user flow to force a login vs. a verify (new user). Details in spec for how to manage the flows. |
@NejcZdovc re-opening issue and restarting case flow from Android. In the discussion with Uphold, I missed updating the entire Android state flow here. if user has <25 bat, they cannot verify a new wallet. Wallet needs to exist (this flow is working well) -- this seems like working as expected. For a user is a pre-existing wallet user, and relogins back successfully, then enable Add-Funds and Withdraw. Alternative path for user with < 25 BAT (for desktop only); keep Add Funds and Withdraw; any clicks with a non ID checked wallet forces user to login. Do not take user to verify wallet modal (that will create a lot of confusion and breaks logic of the minimal 25 BAT value) cc @LaurenWags |
fyi @srirambv on #9723 (comment) to confirm Android matches this expected result |
@mandar-brave closing this one as it was already merged, please open a new issue |
@LaurenWags @srirambv there was no requirement for Android for the "relogin" use case as yet. Will file a P3 for Android separately. |
Verification passed on
Verified that click on
Verification passed on
Verified that click on
Verified passed with
Confirmed Cancel button closes the message box. This is the message that displays on brave://rewards page if you attempt to login with a non-KYC'd account: Confirmed close button closes the message box. In addition to the test plan from above, also verified the following scenarios:
|
Details captured in the Android issue here: #9636
cc @bradleyrichter @jenn-rhim for opinion on any design specific changes.
This is a P2 that should hit BR on Desktop after prelim work.
The text was updated successfully, but these errors were encountered: