Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uphold KYC wallet limitation (new issue) #10855

Closed
mandar-brave opened this issue Jul 22, 2020 · 1 comment · Fixed by brave/brave-core#6217
Closed

Uphold KYC wallet limitation (new issue) #10855

mandar-brave opened this issue Jul 22, 2020 · 1 comment · Fixed by brave/brave-core#6217
Assignees
@NejcZdovc
Labels
feature/rewards OS/Desktop priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.12.x - Release #1

Comments

@mandar-brave
Copy link

mandar-brave commented Jul 22, 2020 •
edited by NejcZdovc
Loading

if user has <25 bat keep Add Funds and Withdraw; any clicks with a non ID checked wallet forces user to login. Do not take user to verify wallet modal (that will create a lot of confusion and breaks logic of the minimal 25 BAT value)

ref: #9723
@mandar-brave mandar-brave added feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. OS/Desktop labels Jul 22, 2020
@NejcZdovc NejcZdovc self-assigned this Jul 22, 2020
@LaurenWags LaurenWags mentioned this issue Jul 22, 2020
Merged
32 tasks
@NejcZdovc NejcZdovc added this to the 1.13.x - Nightly milestone Jul 27, 2020
@NejcZdovc NejcZdovc mentioned this issue Jul 27, 2020
Merged
32 tasks
NejcZdovc added a commit to brave/brave-core that referenced this issue Jul 27, 2020
@NejcZdovc
Fixes panel actions for uphold limit
f6a5db6 
Resolves brave/brave-browser#10855
@brave-builds brave-builds mentioned this issue Jul 27, 2020
Merged
4 tasks
@LaurenWags LaurenWags mentioned this issue Jul 27, 2020
Closed
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jul 29, 2020 •
edited by btlechowski
Loading

Verification passed on


Brave | 1.12.104 Chromium: 84.0.4147.89 (Official Build) dev (64-bit)
-- | --
Revision | 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS | Windows 10 OS Version 1903 (Build 18362.959)

Clean profile with wallet balance zero

  • Ensured that Sign in to Uphold page is displayed upon clicking on Add Funds and Withdraw Funds

Clean profile with wallet balance 25 BAT

  • Ensured that Verify wallet page is displayed upon clicking on Add Funds and Withdraw Funds

Clean profile with wallet balance 24 BAT

  • Ensured that Sign in to Uphold page is displayed upon clicking on Add Funds and Withdraw Funds

Connect KYC'd account which has wallet balance less than 25 BAT

  • Ensured that Uphold Add fund or Withdraw page is displayed upon clicking on Add Funds and Withdraw Funds

Verified passed with

Brave | 1.12.105 Chromium: 84.0.4147.105 (Official Build) (64-bit)
-- | --
Revision | a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS | macOS Version 10.14.6 (Build 18G3020)

Screen Shot 2020-08-03 at 9 51 52 AM

  • Confirmed if you have less than 25 BAT balance, clicking on Add Funds or Withdraw Funds from brave://rewards page shows the login message

Screen Shot 2020-08-03 at 9 52 19 AM

  • Confirmed Cancel button closes message
  • Confirmed Login button opens login page for Uphold
  • Confirmed able to login with KYC'd account
  • Confirmed if more than >=25 BAT balance, clicking on Add Funds or Withdraw Funds shows normal verify modal

Verification passed on

Brave 1.12.105 Chromium: 84.0.4147.105 (Official Build) (64-bit)
Revision a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS Ubuntu 18.04 LTS

  • Verified test plan from Fixes panel actions for uphold limit brave-core#6217

  • Confirmed if you have less than 25 BAT balance, clicking on Add Funds from panel shows the login message
    image

  • Confirmed if you have less than 25 BAT balance, clicking on Add Funds or Withdraw Funds from brave://rewards page shows the login message
    image

  • Confirmed Cancel button closes message

  • Confirmed Login button opens login page for Uphold

  • Confirmed able to login with KYC'd account

  • Confirmed if more than >=25 BAT balance, clicking on Add Funds or Withdraw Funds shows normal verify modal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards OS/Desktop priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.12.x - Release #1
Development

Successfully merging a pull request may close this issue.

Fixes panel actions for uphold limit brave/brave-core
5 participants
@NejcZdovc @LaurenWags @btlechowski @mandar-brave @GeetaSarvadnya