Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes panel actions for uphold limit #6217

Merged
merged 1 commit into from
Jul 27, 2020
Merged

Fixes panel actions for uphold limit #6217

merged 1 commit into from
Jul 27, 2020

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Jul 27, 2020

Resolves brave/brave-browser#10855

Submitter Checklist:

Test Plan:

  • enable rewards
  • go to rewards page
  • make sure that if you have < 25 BAT you see login message if you click on add/withdraw funds

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc added this to the 1.13.x - Nightly milestone Jul 27, 2020
@NejcZdovc NejcZdovc requested a review from a team July 27, 2020 15:55
@NejcZdovc NejcZdovc self-assigned this Jul 27, 2020
@NejcZdovc NejcZdovc requested review from emerick and zenparsing and removed request for a team July 27, 2020 15:55
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NejcZdovc NejcZdovc added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip Do not run CI builds (except noplatform) and removed CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS labels Jul 27, 2020
@NejcZdovc NejcZdovc merged commit e5e0a87 into master Jul 27, 2020
@NejcZdovc NejcZdovc deleted the uphold-limit branch July 27, 2020 16:25
brave-builds pushed a commit that referenced this pull request Jul 27, 2020
@LaurenWags
Copy link
Member

Verified using

Brave | 1.13.50 Chromium: 84.0.4147.105 (Official Build) nightly (64-bit)
-- | --
Revision | a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS | macOS Version 10.14.6 (Build 18G3020)
  • Verified test plan from description
  • Confirmed if you have less than 25 BAT balance, clicking on Add Funds from panel shows the login message

Screen Shot 2020-07-28 at 8 37 17 AM

  • Confirmed if you have less than 25 BAT balance, clicking on Add Funds or Withdraw Funds from brave://rewards page shows the login message

Screen Shot 2020-07-28 at 8 37 34 AM

  • Confirmed Cancel button closes message
  • Confirmed Login button opens login page for Uphold
  • Confirmed able to login with KYC'd account
  • Confirmed if you have over 25 BAT balance, clicking on Add Funds from panel shows the normal verify modal
  • Confirmed if you have over 25 BAT balance, clicking on Add Funds or Withdraw Funds from brave://rewards page shows the normal verify modal

Screen Shot 2020-07-28 at 8 50 55 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip Do not run CI builds (except noplatform) feature/rewards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uphold KYC wallet limitation (new issue)
4 participants