Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for initial rewards API parameter fetch from server (uplift to 1.11.x) #6050

Merged
merged 1 commit into from
Jul 14, 2020

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Jul 9, 2020

Uplift of #6002
Resolves brave/brave-browser#10438

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@LaurenWags
Copy link
Member

Per internal discussions, this was tested using the PR build (https://bravesoftware.slack.com/archives/CMH8DU4TF/p1594303165277600) due to Rewards changes in 1.12.x and 1.13.x. Logged brave/brave-browser#10717 for follow up as discussed in https://bravesoftware.slack.com/archives/CB0KCRCQN/p1594665166331300

Scenario 1 from brave/brave-browser#10438:

  1. Clean profile 1.10.97
  2. Enable rewards
  3. Change AC settings values except for monthly payment (keep the monthly payment as it is which 20 BAT) - Note, it does not matter if you have brave://rewards page open or closed, result on 1.11.x is the same
  4. Upgrade profile to 1.11.x (PR build)
  5. Open brave://rewards if necessary, Look for AC Monthly Payment value
    --> blank in AC table, you can view the drop down to see values (no option is checked though)
    --> if you open AC settings, Monthly Payment box is blank/narrow, but you can click on it to view other options (no option is checked though)
    --> Page refresh fixes this

Scenario 2 from brave/brave-browser#10438:

  1. Clean profile 1.10.97
  2. Enable rewards
  3. Change AC Monthly Budget to some other value (like 100 BAT) - Note, it does not matter if you have brave://rewards page open or closed, result on 1.11.x is the same
  4. Upgrade profile to 1.11.x (PR build)
  5. Open brave://rewards if necessary, Look for AC Monthly Payment value
    --> blank in AC table, you can view the drop down to see values (no option is checked though)
    --> if you open AC settings, Monthly Payment box is blank/narrow, but you can click on it to view other options (no option is checked though)
    --> Page refresh fixes this

Scenario 3 from brave/brave-browser#10438 (comment):

  • is fixed and working as expected

@kjozwiak
Copy link
Member

npm run audit_deps failed on all platforms due to lodash which is a known issue and has been fixed in 1.13.x and 1.12.x.

test-browser failed Linux as per https://ci.brave.com/job/pr-brave-browser-pr6002_ksmith-wait-for-api-params_1.11.x/1/execution/node/459/log/

08:18:06  1 test crashed:
08:18:06      BraveRewardsBrowserTest.ShowACPercentInThePanel (../../brave/components/brave_rewards/browser/rewards_service_browsertest.cc:2802)

@NejcZdovc known intermittent issue? I don't remember seeing this one before ☝️

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.11.x approved after deliberating with @brave/uplift-approvers. QA verified the PR on 1.11.x via PR builds as per #6050 (comment).

@kjozwiak kjozwiak merged commit 2143a0b into 1.11.x Jul 14, 2020
@kjozwiak kjozwiak deleted the pr6002_ksmith-wait-for-api-params_1.11.x branch July 14, 2020 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants