Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Flash default to GetFlashPluginContentSetting #653

Closed
wants to merge 89 commits into from
Closed

Move Flash default to GetFlashPluginContentSetting #653

wants to merge 89 commits into from

Conversation

pilgrim-brave
Copy link
Contributor

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

simonhong and others added 3 commits October 16, 2018 20:30
@simonhong
Consider Qwant search provider as a initial provider in tor window
cd8ede4 
If Qwant is default prepopulate search provider, use it as an
initial search engine provider of tor window. Otherwise, DDG is used.
When user changes search provider setting, it will be persisted.
@pilgrim-brave
Move cookie defaults to GetCookieSetting
4e0ccf2 
Fixes brave/brave-browser#1449

Fixes brave/brave-browser#1592
@pilgrim-brave
Move Flash default to GetFlashPluginContentSetting
a52a235
@yrliou yrliou self-requested a review October 16, 2018 19:47
yrliou
yrliou reviewed Oct 16, 2018
View reviewed changes
Copy link
Member

@yrliou yrliou left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this PR with a fresh profile, without the rule, I think the UI/UX is effected and sometimes looks a bit weird.
First, the flash setting UI in settings was shown as ask instead of block.
screen shot 2018-10-16 at 3 47 27 pm

Also, the flow of visiting of a page with flash is a bit different from current behavior(See #116 for the current flow).
The page will first be shown as below (I think it's the behavior for ask but I'm not sure) instead of showing adobe is blocked directly.
screen shot 2018-10-16 at 4 05 33 pm
The flash is blocked content settings bubble will be shown after clicking the element, which is expected from what you did in this PR.
Click the content settings bubble to run flash this time, the page info is shown as below, but it was Block(default) before this PR.
screen shot 2018-10-16 at 4 06 19 pm

@bbondy
Copy link
Member

bbondy commented Oct 17, 2018

Confirming @diracdeltas wants block first and explicit opt in, so no change in behaviour is ideal.

Jason Sadler and others added 5 commits October 16, 2018 21:36
Fixes brave/brave-browser#1636
850fb82
Merge pull request #656 from jasonrsadler/seed-deriv-check
97fc2ec 
Correctly check result of seed derivation from passphrase
@simonhong
Show Qwant newtab in tor window when qwant is used in german/france
38e2720 
Otherwise, DDG newetab is used in tor window newtab.
@mkarolin
Fixes (hopefully) crashes when downloading an item due to attempting to
273f276 
use BraveDownloadItemView after it is deleted by the base class on
download completion.

Fixes brave/brave-browser#1628
@bbondy
Merge pull request #658 from brave/maxk-fix-crash-downloading
7e4770a 
Fixes crashes when downloading an item (repro'd with a .crx)
@bbondy
Copy link
Member

bbondy commented Oct 17, 2018

Pls update PR description with Fix too. Thanks!

bbondy and others added 24 commits October 18, 2018 07:51
@bbondy
Merge pull request #676 from brave/proxying_sbmodel
8c9a96c 
Proxying requests for safe browsing client model through brave proxy
@NejcZdovc
Fixes upgrade path
87b8148 
Resolves brave/brave-browser#1657
@NejcZdovc
Adds wallet creation failed flow
59ecbc5 
Resolves brave/brave-browser#1687
@NejcZdovc
Removes donation amounts from panel
f18548f
@NejcZdovc
Merge pull request #687 from brave/upgrade-path
549fe7d 
Fixes upgrade path
@NejcZdovc
Merge pull request #689 from brave/wallet-failed
db5a6d1 
Adds wallet creation failed flow
@NejcZdovc
Merge pull request #680 from brave/plugins_3
7b869fb 
Prevent connections to www.gstatic.com plugins_mac.json
@NejcZdovc
Fixes panel text for rewards
3cc31e1 
Resolves brave/brave-browser#1635
@NejcZdovc
Merge pull request #690 from brave/panel_text
45cf7c5 
Fixes panel text for rewards
@bbondy
Add contributors for founding Brave-Core members that asked to be inc…
72706f6 
…luded

If I missed anyone, please feel free to add your name, I did a channel ping in #brave-core for those that wanted in this list and I made sure everyone there was in this list.
@bbondy
Merge pull request #651 from brave/mpilgrim_cookies
a52c537 
Move cookie defaults to GetCookieSetting
@bbondy
Merge pull request #691 from brave/contributors
13520e3 
Add contributors for founding Brave-Core members that asked to be inc…
@NejcZdovc
Fixes notification remove not wokring
565abb8
@NejcZdovc
Merge pull request #692 from brave/notification-remove
03ef7e8 
Fixes notification remove not working
@bsclifton
Changes made per feedback from @davidtemkin
22d2b49 
Auditors: @simonhong
@bsclifton
Merge pull request #685 from brave/show_ddg_in_qwant_region
0be354a 
Show DDG newtab in Qwant region if Qwant is not used
@bsclifton
Update per @mkarolin :)
07b3881
@bsclifton
Merge pull request #694 from brave/bsc-contributors
6be28e0 
Update per @mkarolin :)
@bbondy
Update support email
841c062 
Fix brave/brave-browser#1702
@bsclifton
Merge pull request #695 from brave/update-email
033bdb8 
Update support email
@pilgrim-brave
Move Flash default to GetFlashPluginContentSetting
0d46884
@pilgrim-brave
.
63f183a
@pilgrim-brave
Move Flash default to GetFlashPluginContentSetting
4dfcf24
@pilgrim-brave
Merge branch 'mpilgrim_flash' of github.com:brave/brave-core into mpi…
4738459 
…lgrim_flash
@pilgrim-brave pilgrim-brave deleted the mpilgrim_flash branch October 19, 2018 15:04
@pilgrim-brave pilgrim-brave mentioned this pull request Oct 19, 2018
Merged
18 tasks
fmarier pushed a commit that referenced this pull request Oct 29, 2019
@simonhong
Merge pull request #653 from brave/copy_mac_app_icon
d5bc16f 
Copy proper app icon to /chrome/app/theme/mac/app.icns
petemill pushed a commit that referenced this pull request Jul 27, 2020
@simonhong
Merge pull request #653 from brave/copy_mac_app_icon
486b325 
Copy proper app icon to /chrome/app/theme/mac/app.icns
petemill pushed a commit that referenced this pull request Jul 28, 2020
@simonhong
Merge pull request #653 from brave/copy_mac_app_icon
7375a22 
Copy proper app icon to /chrome/app/theme/mac/app.icns
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yrliou yrliou yrliou left review comments

@bbondy bbondy Awaiting requested review from bbondy

Assignees

@pilgrim-brave pilgrim-brave

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.