Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split ios and macos rust deps #7259

Merged
merged 1 commit into from
Nov 26, 2020
Merged

split ios and macos rust deps #7259

merged 1 commit into from
Nov 26, 2020

Conversation

mihaiplesa
Copy link
Collaborator

@mihaiplesa mihaiplesa commented Nov 26, 2020

Resolves brave/brave-browser#12896

Submitter Checklist:

  • There is a ticket for my issue.
  • Used Github auto-closing keywords in the commit message.
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed).
  • Requested a security/privacy review as needed.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@mihaiplesa mihaiplesa added CI/skip-android Do not run CI builds for Android CI/skip-windows labels Nov 26, 2020
@mihaiplesa mihaiplesa self-assigned this Nov 26, 2020
@mihaiplesa mihaiplesa requested review from antonok-edm, tmancey, kylehickinson, justnom and linhkikuchi and removed request for antonok-edm November 26, 2020 09:31
@mihaiplesa mihaiplesa added this to the 1.19.x - Nightly milestone Nov 26, 2020
@mihaiplesa mihaiplesa removed CI/skip-android Do not run CI builds for Android CI/skip-windows labels Nov 26, 2020
Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

@mihaiplesa mihaiplesa merged commit 69bb11c into master Nov 26, 2020
@mihaiplesa mihaiplesa deleted the mplesa-rust-deps-split branch November 26, 2020 11:13
@mihaiplesa mihaiplesa mentioned this pull request Dec 24, 2020
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split Rust deps for iOS and macOS
3 participants