Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macos arm64 support 1.18.x #7501

Merged
merged 4 commits into from
Dec 27, 2020
Merged

macos arm64 support 1.18.x #7501

merged 4 commits into from
Dec 27, 2020

Conversation

mihaiplesa
Copy link
Collaborator

@mihaiplesa mihaiplesa commented Dec 24, 2020

For brave/brave-browser#12819
Uplift of #7208 and #7259 and #7219 and #7412

Submitter Checklist:

  • There is a ticket for my issue.
  • Used Github auto-closing keywords in the commit message.
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed).
  • Requested a security/privacy review as needed.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@mihaiplesa mihaiplesa self-assigned this Dec 24, 2020
@mihaiplesa mihaiplesa requested a review from a team December 24, 2020 20:32
@mihaiplesa mihaiplesa requested a review from iefremov as a code owner December 25, 2020 20:10
cargo checksum fixes
@mihaiplesa mihaiplesa force-pushed the mplesa-macos-arm64-1.18.x branch from 1f099c4 to caca724 Compare December 25, 2020 20:40
@mihaiplesa mihaiplesa changed the title brave macos rust deps split and arm64 support macos arm64 support 1.18.x Dec 27, 2020
@mihaiplesa mihaiplesa added this to the 1.18.x - Release #3 milestone Dec 27, 2020
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.18.x approved after deliberating with @brave/uplift-approvers. @mihaiplesa verified the PR and ensured the arm64 builds and Widevine was working on Nightly.

@kjozwiak kjozwiak merged commit d427987 into 1.18.x Dec 27, 2020
@kjozwiak kjozwiak deleted the mplesa-macos-arm64-1.18.x branch December 27, 2020 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants