Fix #8056: Update P3A callout text.

brave · Sep 18, 2023 · b90906c · b90906c
1 parent a24129a
commit b90906c
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/Sources/Brave/Frontend/Browser/BrowserViewController/BrowserViewController+Callout.swift b/Sources/Brave/Frontend/Browser/BrowserViewController/BrowserViewController+Callout.swift
@@ -75,7 +75,7 @@ extension BrowserViewController {
         toggleTitle: Strings.Callout.p3aCalloutToggleTitle,
         details: Strings.Callout.p3aCalloutDescription,
         linkDescription: Strings.Callout.p3aCalloutLinkTitle,
-        primaryButtonTitle: Strings.done,
+        primaryButtonTitle: Strings.P3A.continueButton,
         toggleAction: { [weak self] isOn in
           self?.braveCore.p3aUtils.isP3AEnabled = isOn
         },

diff --git a/Sources/BraveStrings/BraveStrings.swift b/Sources/BraveStrings/BraveStrings.swift
@@ -4576,6 +4576,11 @@ extension Strings {
       "p3a.settingSubtitle", tableName: "BraveShared", bundle: .module,
       value: "Anonymised P3A info helps Brave estimate overall usage and ensure we're improving popular features.",
       comment: "A subtitle shown on the setting that toggles analytics on Brave.")
+
+    public static let continueButton = NSLocalizedString(
+      "p3a.continue", tableName: "BraveShared", bundle: .module,
+      value: "Continue",
+      comment: "A button to proceed with the rest of the user onboarding after they see the P3A introduction. It means to continue browsing or continue with the rest of the onboarding")
   }
 }
 

diff --git a/Sources/Onboarding/Welcome/WelcomeViewController.swift b/Sources/Onboarding/Welcome/WelcomeViewController.swift
@@ -364,7 +364,7 @@ public class WelcomeViewController: UIViewController {
         toggleTitle: Strings.Callout.p3aCalloutToggleTitle,
         details: Strings.Callout.p3aCalloutDescription,
         linkDescription: Strings.Callout.p3aCalloutLinkTitle,
-        primaryButtonTitle: Strings.done,
+        primaryButtonTitle: Strings.P3A.continueButton,
         toggleAction: { [weak self] isOn in
           self?.p3aUtilities.isP3AEnabled = isOn
         },