Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Small P3A Onboarding text update #8056

Closed
anthonypkeane opened this issue Sep 13, 2023 · 2 comments · Fixed by #8083
Closed

Small P3A Onboarding text update #8056

anthonypkeane opened this issue Sep 13, 2023 · 2 comments · Fixed by #8083

Comments

@anthonypkeane
Copy link

anthonypkeane commented Sep 13, 2023

Description:

Linked to #1938

Please update the word Done on the P3A screen to Continue

Question for Devs, will Start Browsing easily fit in the UI?

@iccub
Copy link
Contributor

iccub commented Sep 13, 2023

We aim to avoid long text for buttons cc @jenn-rhim

@anthonypkeane anthonypkeane added blocked If a ticket is blocked for some reason, if not using a sub-block label, please provide info in issue and removed blocked If a ticket is blocked for some reason, if not using a sub-block label, please provide info in issue labels Sep 14, 2023
@iccub iccub added this to the 1.58 milestone Sep 18, 2023
@iccub iccub self-assigned this Sep 18, 2023
iccub added a commit that referenced this issue Sep 18, 2023
@hffvld
Copy link
Collaborator

hffvld commented Sep 26, 2023

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 [iOS 17.0]
Brave build: 1.58 (23.9.22.13)
BraveCore: 1.58.129 (117.0.5938.88)

STEPS:

  1. Fresh install and launch Brave
  2. Select Brave to be the default browser or skip it
  3. Observe Help make Brave better. screen > Verify

ACTUAL RESULTS:

  • Verified that Continue button is shown on Help make Brave better. screen
  • Verified new user can tap Continue and land on NTP

1 2
1 2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants