Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable reset sync progress marker study #570

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

AlexeyBarabash
Copy link
Contributor

PR to main branch for issue #569

@AlexeyBarabash AlexeyBarabash requested a review from a team as a code owner March 28, 2023 14:44
@AlexeyBarabash AlexeyBarabash self-assigned this Mar 28, 2023
@AlexeyBarabash AlexeyBarabash merged commit 9fc6714 into main Mar 30, 2023
@AlexeyBarabash AlexeyBarabash deleted the disable-sync-reset-progress branch March 30, 2023 15:27
@kjozwiak
Copy link
Member

kjozwiak commented Apr 13, 2023

Desktop & Android verifications on Nightly

Win 11 x64 Test Cases

SyncResetProgressTokenStudy:Disabled

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.52.42 Chromium: 112.0.5615.87 (Official Build) nightly (64-bit)
-- | --
Revision | 12315abe04d2dc2cac3055bd52ce662b2e742fbe-refs/branch-heads/5615_49@{#4}
OS | Windows 11 Version 22H2 (Build 22621.1413)
  • launched 1.52.42 Chromium: 112.0.5615.87 using the terminal/CLI switch
    • brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that SyncResetProgressTokenStudy wasn't being displayed via brave://version
  • restarted the browser and ensured that SyncResetProgressTokenStudy:Default via brave://version
  • imported several bookmarks via brave://bookmarks and visited brave://settings/braveSync/setup
  • clicked on Start a new Sync Chain -> Phone/Tablet and scanned the QA code with the Android device mentioned below
  • removed/added several bookmarks/folders and ensured everything was being synced without any issues
Example Example Example
nightlyDesktop1 nightlyDesktop2 nightlyDesktop3

Pixel 6 running Android 13 Test Cases

SyncResetProgressTokenStudy:Disabled

Went through the STR/Cases mentioned via brave/brave-core#10408 (comment) and ensured that Brave was using https://variations.bravesoftware.com/seed which is the staging URL.

image

Verification PASSED on Pixel 6 running Android 13 using the following build(s):

Brave | 1.52.42 Chromium: 112.0.5615.87 (Official Build) canary (32-bit)
--- | ---
Revision | 12315abe04d2dc2cac3055bd52ce662b2e742fbe-refs/branch-heads/5615_49@{#4}
OS | Android 13; Build/TQ2A.230405.003.E1
  • launched 1.52.42 Chromium: 112.0.5615.87 and ensured that SyncResetProgressTokenStudy isn't visible via brave://version
  • restarted the browser and ensured that SyncResetProgressTokenStudy:Disabled via brave://version
  • joined sync chain that was started with the desktop as per above via Settings -> Sync -> Scan or enter sync code
  • once the QR code was scanned, ensured that all the bookmarks from both Desktop & Android were synced correctly
  • removed/added several bookmarks/folders and ensured everything was being synced without any issues
Example Example Example Example Example
Screenshot_20230413-143244 Screenshot_20230413-143255 Screenshot_20230413-143401 Screenshot_20230413-143414 Screenshot_20230413-143417

Desktop & Android verifications on BETA

Win 11 x64 Test Cases

SyncResetProgressTokenStudy:Disabled

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.51.87 Chromium: 112.0.5615.49 (Official Build) beta (64-bit)
-- | --
Revision | bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS | Windows 11 Version 22H2 (Build 22621.1413)
  • launched 1.51.87 Chromium: 112.0.5615.49 using the terminal/CLI switch
    • brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that SyncResetProgressTokenStudy wasn't being displayed via brave://version
  • restarted the browser and ensured that SyncResetProgressTokenStudy:Default via brave://version
  • imported several bookmarks via brave://bookmarks and visited brave://settings/braveSync/setup
  • clicked on Start a new Sync Chain -> Phone/Tablet and scanned the QA code with the Android device mentioned below
  • removed/added several bookmarks/folders and ensured everything was being synced without any issues
Example Example Example
image image image

Pixel 6 running Android 13 Test Cases

SyncResetProgressTokenStudy:Disabled

Went through the STR/Cases mentioned via brave/brave-core#10408 (comment) and ensured that Brave was using https://variations.bravesoftware.com/seed which is the staging URL.

image

Verification PASSED on Pixel 6 running Android 13 using the following build(s):

Brave | 1.51.87 Chromium: 112.0.5615.49 (Official Build) beta (32-bit)
--- | ---
Revision | bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS | Android 13; Build/TQ2A.230405.003.E1
  • launched 1.51.87 Chromium: 112.0.5615.49 and ensured that SyncResetProgressTokenStudy isn't visible via brave://version
  • restarted the browser and ensured that SyncResetProgressTokenStudy:Disabled via brave://version
  • joined sync chain that was started with the desktop as per above via Settings -> Sync -> Scan or enter sync code
  • once the QR code was scanned, ensured that all the bookmarks from both Desktop & Android were synced correctly
  • removed/added several bookmarks/folders and ensured everything was being synced without any issues
Example Example Example Example Example
Screenshot_20230413-151247 Screenshot_20230413-151313 Screenshot_20230413-151429 Screenshot_20230413-151438 Screenshot_20230413-151442

Desktop & Android verifications on Release

Win 11 x64 Test Cases

SyncResetProgressTokenStudy:Disabled

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.50.118 Chromium: 112.0.5615.87 (Official Build) (64-bit)
-- | --
Revision | 12315abe04d2dc2cac3055bd52ce662b2e742fbe-refs/branch-heads/5615_49@{#4}
OS | Windows 11 Version 22H2 (Build 22621.1413)
  • launched 1.50.118 Chromium: 112.0.5615.87 using the terminal/CLI switch
    • brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that SyncResetProgressTokenStudy wasn't being displayed via brave://version
  • restarted the browser and ensured that SyncResetProgressTokenStudy:Default via brave://version
  • imported several bookmarks via brave://bookmarks and visited brave://settings/braveSync/setup
  • clicked on Start a new Sync Chain -> Phone/Tablet and scanned the QA code with the Android device mentioned below
  • removed/added several bookmarks/folders and ensured everything was being synced without any issues
Example Example Example
image image image

Pixel 6 running Android 13 Test Cases

SyncResetProgressTokenStudy:Disabled

Went through the STR/Cases mentioned via brave/brave-core#10408 (comment) and ensured that Brave was using https://variations.bravesoftware.com/seed which is the staging URL.

image

Verification PASSED on Pixel 6 running Android 13 using the following build(s):

Brave | 1.50.114 Chromium: 112.0.5615.49 (Official Build) (32-bit)
--- | ---
Revision | bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS | Android 13; Build/TQ2A.230405.003.E1
  • launched 1.50.114 Chromium: 112.0.5615.49 and ensured that SyncResetProgressTokenStudy isn't visible via brave://version
  • restarted the browser and ensured that SyncResetProgressTokenStudy:Disabled via brave://version
  • joined sync chain that was started with the desktop as per above via Settings -> Sync -> Scan or enter sync code
  • once the QR code was scanned, ensured that all the bookmarks from both Desktop & Android were synced correctly
  • removed/added several bookmarks/folders and ensured everything was being synced without any issues
Example Example Example Example Example
Screenshot_20230414-012731 Screenshot_20230414-012740 Screenshot_20230414-012813 Screenshot_20230414-012838 Screenshot_20230414-012842

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants