Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable reset sync progress marker feature #620

Merged
merged 1 commit into from
May 9, 2023
Merged

Re-enable reset sync progress marker feature #620

merged 1 commit into from
May 9, 2023

Conversation

AlexeyBarabash
Copy link
Contributor

Resolves #619

Basically this is revert of #570

@AlexeyBarabash AlexeyBarabash self-assigned this May 2, 2023
@AlexeyBarabash AlexeyBarabash requested a review from a team as a code owner May 2, 2023 15:29
@AlexeyBarabash AlexeyBarabash force-pushed the reenable_reset_sync_progress_token branch from 794faa9 to 7463012 Compare May 9, 2023 10:30
@AlexeyBarabash
Copy link
Contributor Author

Merging to test on staging server

@AlexeyBarabash AlexeyBarabash merged commit 5963ea8 into main May 9, 2023
@AlexeyBarabash AlexeyBarabash deleted the reenable_reset_sync_progress_token branch May 9, 2023 10:42
AlexeyBarabash added a commit that referenced this pull request May 9, 2023
@AlexeyBarabash
Re-enable reset sync progress marker feature (#620)
636223f
@AlexeyBarabash AlexeyBarabash mentioned this pull request May 9, 2023
Merged
@kjozwiak
Copy link
Member

kjozwiak commented May 17, 2023 •
edited
Loading

Nightly Verification on Win 11 x64

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.53.44 Chromium: 114.0.5735.26 (Official Build) nightly (64-bit)
-- | --
Revision | 7075cbb66f0542ac3e01ddfde6b813e7d61118a5-refs/branch-heads/5735@{#454}
OS | Windows 11 Version 22H2 (Build 22621.1702)
  • launched 1.53.44 Chromium: 114.0.5735.26 using the following terminal/CLI switches
    • brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured none of the studies appeared via brave://version (including SyncResetProgressTokenStudy)
  • restarted 1.53.44 Chromium: 114.0.5735.26 using the same switches mentioned above
    • brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that SyncResetProgressTokenStudy is not being listed under brave://version

nightlySync1

BETA Verification on Win 11 x64

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.52.100 Chromium: 113.0.5672.92 (Official Build) beta (64-bit)
-- | --
Revision | b6f521170062a1fa8a82c33fb223b06fec566da1-refs/branch-heads/5672_63@{#10}
OS | Windows 11 Version 22H2 (Build 22621.1702)
  • launched 1.52.100 Chromium: 113.0.5672.92 using the following terminal/CLI switches
    • brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured none of the studies appeared via brave://version (including SyncResetProgressTokenStudy)
  • restarted 1.52.100 Chromium: 113.0.5672.92 using the same switches mentioned above
    • brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that SyncResetProgressTokenStudy is not being listed under brave://version

image

Release Verification on Win 11 x64

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.51.114 Chromium: 113.0.5672.92 (Official Build) (64-bit)
-- | --
Revision | b6f521170062a1fa8a82c33fb223b06fec566da1-refs/branch-heads/5672_63@{#10}
OS | Windows 11 Version 22H2 (Build 22621.1702)
  • launched 1.51.114 Chromium: 113.0.5672.92 using the following terminal/CLI switches
    • brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured none of the studies appeared via brave://version (including SyncResetProgressTokenStudy)
  • restarted 1.51.114 Chromium: 113.0.5672.92 using the same switches mentioned above
    • brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that SyncResetProgressTokenStudy is not being listed under brave://version

image

kjozwiak pushed a commit that referenced this pull request May 17, 2023
@AlexeyBarabash
Re-enable reset sync progress marker feature (#620) (#627)
9e1cfb7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@AlexeyBarabash AlexeyBarabash

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re-enable feature ResetProgressMarkerOnCommitFailures
2 participants
@AlexeyBarabash @kjozwiak