Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Commit

Permalink
allow search icon to show while loading (#6532)
Browse files Browse the repository at this point in the history
Allow the search icon to show while loading. This removes a display lag
time for URL bar icons.

Fixes #6518.
  • Loading branch information
kaizensoze authored and bsclifton committed Jan 23, 2017
1 parent bc33c80 commit 030d907
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions app/renderer/components/urlBarIcon.js
Original file line number Diff line number Diff line change
Expand Up @@ -35,18 +35,15 @@ class UrlBarIcon extends ImmutableComponent {
}
/**
* search icon:
* - does not show when loading
* - does not show when in title mode
* - shows when urlbar is active (ex: you can type)
* - is a catch-all for: about pages, files, etc
*/
get isSearch () {
const showSearch = this.props.active &&
this.props.loading === false
const showSearch = this.props.active

const defaultToSearch = (!this.isSecure && !this.isInsecure && !showSearch) &&
!this.props.titleMode &&
this.props.loading === false &&
!this.isAboutPage

return showSearch || defaultToSearch
Expand Down

0 comments on commit 030d907

Please sign in to comment.