This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
allow search icon to show while loading #6532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow the search icon to show while loading. This removes a display lag time for URL bar icons. Fixes brave#6518.
|
thanks! I think @bsclifton will be thrilled to review it. |
|
Related PR: #6319 |
bsclifton
force-pushed
the
0.13.1-branch
branch
2 times, most recently
from
0da267f to
7f84176
Compare
cezaraugusto
approved these changes
Jan 18, 2017
bsclifton
pushed a commit
that referenced
this pull request
Jan 18, 2017
Allow the search icon to show while loading. This removes a display lag time for URL bar icons. Fixes #6518.
bsclifton
pushed a commit
that referenced
this pull request
Jan 18, 2017
Allow the search icon to show while loading. This removes a display lag time for URL bar icons. Fixes #6518.
bsclifton
pushed a commit
that referenced
this pull request
Jan 20, 2017
Allow the search icon to show while loading. This removes a display lag time for URL bar icons. Fixes #6518.
NejcZdovc
pushed a commit
to NejcZdovc/browser-laptop
that referenced
this pull request
Jan 23, 2017
Allow the search icon to show while loading. This removes a display lag time for URL bar icons. Fixes brave#6518.
bsclifton
pushed a commit
that referenced
this pull request
Jan 23, 2017
Allow the search icon to show while loading. This removes a display lag time for URL bar icons. Fixes #6518.
bsclifton
pushed a commit
that referenced
this pull request
Jan 24, 2017
Allow the search icon to show while loading. This removes a display lag time for URL bar icons. Fixes #6518.
bsclifton
pushed a commit
that referenced
this pull request
Jan 25, 2017
Allow the search icon to show while loading. This removes a display lag time for URL bar icons. Fixes #6518.
bsclifton
pushed a commit
that referenced
this pull request
Jan 25, 2017
Allow the search icon to show while loading. This removes a display lag time for URL bar icons. Fixes #6518.
This was referenced Feb 3, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the search icon to show while loading. This removes a display lag
time for URL bar icons.
Fixes #6518.
git rebase -ito squash commits (if needed).There are a bunch of tests failing unrelated to this change:
...