Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Commit

Permalink
Merge pull request #5041 from brave/bookmark-icon-position
Browse files Browse the repository at this point in the history
Bookmark Icon position in title mode looks bad
  • Loading branch information
bbondy authored Oct 22, 2016
2 parents 394d1e3 + 77cc262 commit e20eb28
Showing 1 changed file with 13 additions and 9 deletions.
22 changes: 13 additions & 9 deletions js/components/navigationBar.js
Original file line number Diff line number Diff line change
Expand Up @@ -148,15 +148,19 @@ class NavigationBar extends ImmutableComponent {
onClick={this.onHome} />
: null
}
<Button iconClass={this.bookmarked ? 'fa-star' : 'fa-star-o'}
className={cx({
navbutton: true,
bookmarkButton: true,
removeBookmarkButton: this.bookmarked,
withHomeButton: getSetting(settings.SHOW_HOME_BUTTON)
})}
l10nId={this.bookmarked ? 'removeBookmarkButton' : 'addBookmarkButton'}
onClick={this.onToggleBookmark} />
{
!this.titleMode
? <Button iconClass={this.bookmarked ? 'fa-star' : 'fa-star-o'}
className={cx({
navbutton: true,
bookmarkButton: true,
removeBookmarkButton: this.bookmarked,
withHomeButton: getSetting(settings.SHOW_HOME_BUTTON)
})}
l10nId={this.bookmarked ? 'removeBookmarkButton' : 'addBookmarkButton'}
onClick={this.onToggleBookmark} />
: null
}
</div>
<UrlBar ref='urlBar'
sites={this.props.sites}
Expand Down

0 comments on commit e20eb28

Please sign in to comment.