Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Bookmark Icon position in title mode looks bad #5041

Merged
merged 1 commit into from
Oct 22, 2016
Merged

Conversation

jkup
Copy link
Contributor

@jkup jkup commented Oct 21, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Fix #4985

Auditors @bradleyrichter @bsclifton

Test Plan:
screen shot 2016-10-21 at 4 28 48 pm
screen shot 2016-10-21 at 4 28 52 pm

We decided just to hide the bookmark star on titlemode for now. It should show while editing and hide when you click away.

@jkup jkup added this to the 0.12.6dev milestone Oct 21, 2016
@bbondy
Copy link
Member

bbondy commented Oct 22, 2016

++

@bsclifton
Copy link
Member

👌

@jkup jkup deleted the bookmark-icon-position branch October 25, 2016 00:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants