Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Tab preview does not work properly with DnD #10103

Closed
luixxiul opened this issue Jul 24, 2017 · 3 comments · Fixed by #10691
Closed

Tab preview does not work properly with DnD #10103

luixxiul opened this issue Jul 24, 2017 · 3 comments · Fixed by #10691
Assignees
@cezaraugusto
Labels
bug feature/tab-preview misc/drag-and-drop QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/include
Milestone
0.20.x (Release C...

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Jul 24, 2017 •
edited
Loading

Test plan

#10691 (comment)

Describe the issue you encountered: Tab preview does not work properly with drag-and-drop.

tabpreview
@luixxiul luixxiul added this to the 0.20.x (Nightly Channel) milestone Jul 24, 2017
@luixxiul luixxiul mentioned this issue Jul 25, 2017
Merged
7 tasks
@luixxiul luixxiul modified the milestones: 0.21.x (Nightly Channel), 0.20.x (Developer Channel) Aug 9, 2017
@cezaraugusto cezaraugusto modified the milestones: 0.22.x, 0.21.x (Nightly Channel) Aug 22, 2017
@cezaraugusto
Copy link
Contributor

I think we should cancel the preview if tab is being dragged

@cezaraugusto
Copy link
Contributor

actually I'm going to do this ^^^ way. let me know if you disagree

@cezaraugusto
Copy link
Contributor

cc @zentagonist setting to sprint/1 and tagging for 0.20.x as it will be fixed by #10691

@cezaraugusto cezaraugusto modified the milestones: 0.22.x, 0.20.x (Developer Channel) Sep 14, 2017
@cezaraugusto cezaraugusto mentioned this issue Sep 14, 2017
Merged
cezaraugusto added a commit that referenced this issue Sep 14, 2017
@cezaraugusto
do not allow previews if tab is being dragged
1ae75d7 
Auditors: @luixxiul
Fix #10103
cezaraugusto added a commit that referenced this issue Sep 15, 2017
@cezaraugusto
do not allow previews if tab is being dragged
20c19d9 
Auditors: @luixxiul
Fix #10103
cezaraugusto added a commit that referenced this issue Sep 15, 2017
@cezaraugusto
do not allow previews if tab is being dragged
83864a8 
Auditors: @luixxiul
Fix #10103
cezaraugusto added a commit that referenced this issue Sep 19, 2017
@cezaraugusto
do not allow previews if tab is being dragged
384e9c8 
Auditors: @luixxiul
Fix #10103
cezaraugusto added a commit that referenced this issue Sep 21, 2017
@cezaraugusto
do not allow previews if tab is being dragged
c3def82 
Auditors: @luixxiul
Fix #10103
syuan100 pushed a commit to syuan100/browser-laptop that referenced this issue Nov 9, 2017
@cezaraugusto @syuan100
do not allow previews if tab is being dragged
a0c4284 
Auditors: @luixxiul
Fix brave#10103
This was referenced Dec 20, 2017
Closed
Closed
This was referenced Dec 27, 2017
Closed
Closed
Closed
Closed
@srirambv srirambv mentioned this issue Jan 9, 2018
Closed
26 tasks
@kjozwiak kjozwiak mentioned this issue Jan 31, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cezaraugusto cezaraugusto

Labels
bug feature/tab-preview misc/drag-and-drop QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/include
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

Successfully merging a pull request may close this issue.

improve tabs performance and UI with this one simple trick brave/browser-laptop
4 participants
@luixxiul @cezaraugusto @srirambv @LaurenWags