-
Notifications
You must be signed in to change notification settings - Fork 973
Trigger tab preview based on frame key #8902
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test plan works.
e1cab8d
to
c578679
Compare
works as-is but a new state is needed from #8852 so setting as blocked until that is approved |
Pls rebase and remove the needs rebase tag when done. Thanks. |
- Auditors: @bsclifton, @luixxiul - Close: #7606
c578679
to
9ed4403
Compare
rebased, removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the test plans work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change works great! 😄
If you had time available, it would be awesome to have a test to make sure this behavior doesn't accidentally regress
Trigger tab preview based on frame key
Auditors: @bsclifton Addresses #8902 (review)
Auditors: @bsclifton Addresses #8902 (review)
Auditors: @bsclifton Addresses #8902 (review)
Auditors: @bsclifton Addresses #8902 (review)
Is this change covered with automated tests? |
@luixxiul I didn't include new ones but they are covered with existing tests for tab previews |
@cezaraugusto the question occurred to me because of the issue here: #10103 |
ok np, that's related thanks for opening |
Submitter Checklist:
git rebase -i
to squash commits (if needed).Test Plan:
When next tab exists
Static ordering
dynamic ordering
when previous frame is not active
when next tab is null
when frame is closed by close tab shortcut
Reviewer Checklist:
Tests