Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Mute item is missing in the context menu #12472

Closed
NejcZdovc opened this issue Jan 3, 2018 · 0 comments
Closed

Mute item is missing in the context menu #12472

NejcZdovc opened this issue Jan 3, 2018 · 0 comments
Assignees
@NejcZdovc
Labels
feature/context-menu QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.20.x (Release C...

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Jan 3, 2018 •
edited by srirambv
Loading

Test Plan

  1. Open https://www.youtube.com/watch?v=kLiLOkzLetE
  2. Right click on the tab, Mute Tab option should be avialable
  3. Click on Mute Tab should mute the audio

Description

While testing #10545 I noticed that menu option is only shown when you switch to another tab.

Steps to Reproduce

  1. Open https://www.youtube.com/watch?v=kLiLOkzLetE
  2. Mute via context menu is missing

Actual result:

Mute tab is missing

Expected result:
Mute tab menu item should be there

Reproduces how often:

Brave Version

about:brave info:

Reproducible on current live release:

Additional Information

jan-03-2018 09-27-26
@NejcZdovc NejcZdovc added this to the 0.20.x (Beta Channel) milestone Jan 3, 2018
@NejcZdovc NejcZdovc self-assigned this Jan 3, 2018
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jan 3, 2018
@NejcZdovc
Fixes context menu mute item not being displayed
1bcc802 
Resolves brave#12472

Auditors:

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue Jan 3, 2018
Merged
10 tasks
@NejcZdovc NejcZdovc mentioned this issue Jan 3, 2018
Merged
10 tasks
bsclifton added a commit that referenced this issue Jan 3, 2018
@bsclifton
Merge pull request #12475 from NejcZdovc/hotfix/#12472-mute
58b1b8f 
Fixes context menu mute item not being displayed
bsclifton added a commit that referenced this issue Jan 3, 2018
@bsclifton
Merge pull request #12475 from NejcZdovc/hotfix/#12472-mute
63b4659 
Fixes context menu mute item not being displayed
bsclifton added a commit that referenced this issue Jan 3, 2018
@bsclifton
Merge pull request #12475 from NejcZdovc/hotfix/#12472-mute
45e8c5f 
Fixes context menu mute item not being displayed
@LaurenWags LaurenWags mentioned this issue Jan 22, 2018
Closed
34 tasks
@srirambv srirambv mentioned this issue Jan 24, 2018
Closed
@kjozwiak kjozwiak mentioned this issue Jan 31, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
feature/context-menu QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

No branches or pull requests
5 participants
@kjozwiak @bsclifton @NejcZdovc @srirambv @LaurenWags