Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixes context menu mute item not being displayed #12475

Merged
merged 1 commit into from
Jan 3, 2018

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Jan 3, 2018

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Resolves #12472

Auditors:

Test Plan: defined in #12472

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@NejcZdovc NejcZdovc added this to the 0.20.x (Beta Channel) milestone Jan 3, 2018
@NejcZdovc NejcZdovc self-assigned this Jan 3, 2018
@NejcZdovc NejcZdovc requested a review from bsclifton January 3, 2018 13:31
@NejcZdovc
Copy link
Contributor Author

@bsclifton it's basically the same fix that you did for mute/unmute

@codecov-io
Copy link

codecov-io commented Jan 3, 2018

Codecov Report

Merging #12475 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #12475      +/-   ##
==========================================
- Coverage   55.85%   55.82%   -0.04%     
==========================================
  Files         278      278              
  Lines       26996    26996              
  Branches     4364     4364              
==========================================
- Hits        15079    15070       -9     
- Misses      11917    11926       +9
Flag Coverage Δ
#unittest 55.82% <ø> (-0.04%) ⬇️
Impacted Files Coverage Δ
js/stores/appStoreRenderer.js 91.17% <0%> (-8.83%) ⬇️
app/renderer/components/reduxComponent.js 84.37% <0%> (-6.25%) ⬇️
js/stores/windowStore.js 27.25% <0%> (-0.31%) ⬇️

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton merged commit 58b1b8f into brave:master Jan 3, 2018
bsclifton added a commit that referenced this pull request Jan 3, 2018
Fixes context menu mute item not being displayed
bsclifton added a commit that referenced this pull request Jan 3, 2018
Fixes context menu mute item not being displayed
@bsclifton
Copy link
Member

master 58b1b8f
0.21.x 63b4659
0.20.x 45e8c5f

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants