Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Publisher data file should be deleted when wallet is deleted #14758

Closed
ryanml opened this issue Jul 16, 2018 · 1 comment
Closed

Publisher data file should be deleted when wallet is deleted #14758

ryanml opened this issue Jul 16, 2018 · 1 comment
Assignees
@ryanml
Labels
feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.23.x Release 5 ...

Comments

@ryanml
Copy link
Contributor

ryanml commented Jul 16, 2018

Description

Currently when a wallet deletion is processed, ledger-state.json is deleted. publisher-data.json should also be deleted.

Steps to Reproduce

  1. Run Brave
  2. Enable Payments
  3. Delete Wallet

Actual result:
publisher-data.json exists

Expected result:
publisher-data.json should be deleted

Reproduces how often:
100%
@ryanml ryanml added this to the 0.23.x Release 4 milestone Jul 16, 2018
@ryanml ryanml self-assigned this Jul 16, 2018
ryanml added a commit to ryanml/browser-laptop that referenced this issue Jul 16, 2018
@ryanml
Fixes brave#14758, deletes publisher-data.json when wallet is deleted
ff7c4e3
@ryanml ryanml mentioned this issue Jul 16, 2018
Merged
10 tasks
ryanml added a commit to ryanml/browser-laptop that referenced this issue Jul 18, 2018
@ryanml
Fixes brave#14758, deletes publisher-data.json when wallet is deleted
7e1e3c0
ryanml added a commit to ryanml/browser-laptop that referenced this issue Jul 18, 2018
@ryanml
Fixes brave#14758, deletes publisher-data.json when wallet is deleted
136c979
ryanml added a commit to ryanml/browser-laptop that referenced this issue Jul 18, 2018
@ryanml
Fixes brave#14758, deletes publisher-data.json when wallet is deleted
4574be4
ryanml added a commit to ryanml/browser-laptop that referenced this issue Jul 19, 2018
@ryanml
Fixes brave#14758, deletes publisher-data.json when wallet is deleted
d417f56
ryanml added a commit to ryanml/browser-laptop that referenced this issue Jul 31, 2018
@ryanml
Fixes brave#14758, deletes publisher-data.json when wallet is deleted
07c992f
This was referenced Aug 14, 2018
Closed
Closed
Closed
@GeetaSarvadnya
Copy link
Collaborator

GeetaSarvadnya commented Aug 14, 2018 •
edited by kjozwiak
Loading

Verified on Windows x64 with

  • 0.23.80 53a429f
  • Muon 8.0.8
  • libchromiumcontent 68.0.3440.84

Verified on Ubuntu 18 x64 using

  • 0.23.80 53a429f
  • Muon 8.0.8
  • libchromiumcontent 68.0.3440.84

Verified with macOS 10.12.6 using

  • 0.23.80 53a429f
  • Muon 8.0.8
  • libchromiumcontent 68.0.3440.84

@kjozwiak kjozwiak mentioned this issue Aug 28, 2018
Closed
@LaurenWags LaurenWags mentioned this issue Sep 19, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ryanml ryanml

Labels
feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.23.x Release 5 (Release Channel)
Development

No branches or pull requests
5 participants
@kjozwiak @ryanml @srirambv @LaurenWags @GeetaSarvadnya