Deletes publisher-data.json when wallet is deleted

[ryanml]

Fixes #14758

Submitter Checklist:

• Submitted a ticket for my issue if one did not already exist.
• Used Github auto-closing keywords in the commit message.
• Added/updated tests for this change (for new code or code which already has tests).
• Ran git rebase -i to squash commits (if needed).
• Tagged reviewers and labelled the pull request as needed.
• Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

1. Run Brave with a clean profile from this branch
2. Enable Payments
3. Wait ~15 seconds and ensure that publisher-data.json is present in the user profile folder
4. Delete Wallet
5. Ensure that publisher-data.json and ledger-state.json are deleted.
6. Re-enable payments
7. Wait ~15 seconds and ensure that publisher-data.json is generated again

Reviewer Checklist:

• Request a security/privacy review as needed if one was not already requested.

Tests

• Adequate test coverage exists to prevent regressions
• Tests should be independent and work correctly when run individually or as a suite ref
• New files have MPL2 license header

[jasonrsadler]

If we delete wallet and then re enable, do we need to get the publisher-data back?

[ryanml]

@jasonrsadler re enabling payments will recall initialize and the list will be fetched again

[NejcZdovc]

@ryanml please add this to test plan as well

[ryanml]

@NejcZdovc test plan updated

[NejcZdovc]

@ryanml thank you

[NejcZdovc]

7 step is failing for me. File is not generated. It's not created even if I restart the browser

[ryanml]

@NejcZdovc should be fine to re-try now, small oversight :D

[NejcZdovc]

++ will merge after rel 4 is released

[NejcZdovc]

Step 5 is failing for me

[ryanml]

@NejcZdovc the test plan is working as expected for me. @jasonrsadler can you confirm?

[jasonrsadler]

Step 5 works for me but step 7 fails. publisher-data.json does not get recreated. Test plan works for me (edit for having to merge updates in)

should be good to check again if you re-pull

[NejcZdovc]

@ryanml please rebase

[ryanml]

@NejcZdovc rebased

[bsclifton]

master 4888635
0.24.x 2d8d3af
0.23.x f0bc8c0