Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Audio indicator on/off button #1776

Closed
luixxiul opened this issue May 16, 2016 · 5 comments
Closed

Audio indicator on/off button #1776

luixxiul opened this issue May 16, 2016 · 5 comments
Labels
feature/tabsbar QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified regression release-notes/include
Milestone
0.13.3

Comments

@luixxiul
Copy link
Contributor

luixxiul commented May 16, 2016 •
edited by cezaraugusto
Loading

Test plan

#6900 (comment)

youtube

You have to change where to click in order to mute and unmute audio

Test plan

  1. Play a youtube video
  2. Click the indicator to mute
  3. Click the same place to unmute
@AkshayTiwari
Copy link

I'd love to try working on this.
Can you help me with the files for this? I'll try fixing this. @bbondy

@cndouglas
Copy link

@AkshayTiwari browser-laptop/less/tabs.less is the file, and .audioPlaybackActive is the stylesheet element.

@luixxiul
Copy link
Contributor Author

The latest is a correct one.

@bbondy bbondy closed this as completed in 047d515 May 23, 2016
bbondy added a commit that referenced this issue May 23, 2016
@bbondy
Merge pull request #1874 from luixxiul/audioplayback
e141b5f 
Fix #1776 (Audio indicator on/off button)
@luixxiul luixxiul added this to the 0.10.1dev milestone May 23, 2016
@luixxiul luixxiul reopened this Jan 23, 2017
@luixxiul luixxiul modified the milestones: 0.13.1, 0.10.1dev Jan 23, 2017
@bbondy bbondy removed this from the 0.13.1 milestone Jan 28, 2017
@cezaraugusto
Copy link
Contributor

This was also addressed on #6900

@cezaraugusto cezaraugusto mentioned this issue Feb 6, 2017
Merged
4 tasks
@luixxiul
Copy link
Contributor Author

luixxiul commented Feb 6, 2017

Sweet!

bsclifton pushed a commit that referenced this issue Feb 6, 2017
@cezaraugusto @bsclifton
Responsive tab / refactor to Aphrodite
600f53a 
Auditors: @bsclifton, @bbondy

/cc @bradleyrichter

Fix #5431
Fix #6511
Fix #6845
Fix #1776
Fix #100
@bsclifton bsclifton added this to the 0.13.3 milestone Feb 6, 2017
This was referenced Feb 11, 2017
Closed
Closed
Closed
Closed
@luixxiul luixxiul mentioned this issue Apr 2, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature/tabsbar QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified regression release-notes/include
Projects
None yet
Milestone
0.13.3
Development

No branches or pull requests
7 participants
@bbondy @luixxiul @cezaraugusto @bsclifton @AkshayTiwari @srirambv @cndouglas