Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Disable close button on tabs if tab size is too small #5431

Closed
luixxiul opened this issue Nov 6, 2016 · 10 comments · Fixed by #5845, #7799 or #7851
Closed

Disable close button on tabs if tab size is too small #5431

luixxiul opened this issue Nov 6, 2016 · 10 comments · Fixed by #5845, #7799 or #7851

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Nov 6, 2016

Test plan

Under "QA steps" on #7799 (comment)
#7851 (comment)


Describe the issue you encountered: if you click the close button of tab whose size is too small, sometimes you click the close button accidently.

Expected behavior: Disable close button on tabs if tab size is too small.

  • Platform (Win7, 8, 10? macOS? Linux distro?): Windows 10

  • Brave Version: 0.12.8 RC1

  • Steps to reproduce:

    1. Open many tabs
    2. Minimize the width of the window
    3. Select any tab carefully not to close it...
  • Screenshot if needed:

clipboard01

  • Any related issues:
@luixxiul luixxiul added this to the 1.0.0 milestone Nov 6, 2016
@bradleyrichter bradleyrichter modified the milestones: 0.12.9dev, 1.0.0 Nov 6, 2016
@bradleyrichter
Copy link
Contributor

This sounds like a LHF fix. (low hanging fruit)

@bbondy Can we get this in sooner than 1.0?

@bbondy
Copy link
Member

bbondy commented Nov 7, 2016

@cezaraugusto mind grabbing this?

@bsclifton
Copy link
Member

bsclifton commented Nov 28, 2016

Change was backed out with #5886 after we noticed positioning of the audio icon being wrong:
image

The CSS as-is (in tabs.less) is great and works wonderfully... until the window gets smaller than ~520px. I think the changes that were made need to be wrapped with a media query and should only be applied if within the breakpoint that was defined (520px). 😄 Milestone has already been bumped to 0.13.1

cezaraugusto added a commit that referenced this issue Jan 7, 2017
cezaraugusto added a commit that referenced this issue Jan 7, 2017
cezaraugusto added a commit that referenced this issue Jan 8, 2017
cezaraugusto added a commit that referenced this issue Jan 28, 2017
cezaraugusto added a commit that referenced this issue Jan 28, 2017
cezaraugusto added a commit that referenced this issue Jan 28, 2017
@luixxiul
Copy link
Contributor Author

luixxiul commented Mar 22, 2017

Reopening based on the feedback by @srirambv and me.

#7799 (comment)

Test 1 fails as the close button is overlapped on the right side of favicon. And the click area is more than the close button causing it to close the tab when clicked on the favicon

newtabtext

Another adjustment of min-threshold for closeTab would be needed.

@luixxiul luixxiul reopened this Mar 22, 2017
@alexwykoff alexwykoff changed the title Disable close button on tabs if tab size is too small Fixed close button on tabs if tab size is too small Mar 28, 2017
@luixxiul
Copy link
Contributor Author

@cezaraugusto I like your last solution quite well 💯 The next step is to fix #2702.

@luixxiul luixxiul changed the title Fixed close button on tabs if tab size is too small Disable close button on tabs if tab size is too small Sep 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.