-
Notifications
You must be signed in to change notification settings - Fork 973
Disable close button on tabs if tab size is too small #5431
Comments
This sounds like a LHF fix. (low hanging fruit) @bbondy Can we get this in sooner than 1.0? |
@cezaraugusto mind grabbing this? |
Change was backed out with #5886 after we noticed positioning of the audio icon being wrong: The CSS as-is (in |
Auditors: @bsclifton, @bbondy, @bradleyrichter, @jkup Fix #5431
Auditors: @bsclifton, @bbondy, @bradleyrichter, @jkup Fix #5431
Auditors: @bsclifton, @bbondy, @bradleyrichter, @jkup Fix #5431
Auditors: @bsclifton, @bbondy /cc @bradleyrichter Fix #5431 Fix #6511
Auditors: @bsclifton, @bbondy /cc @bradleyrichter Fix #5431 Fix #6511
Auditors: @bsclifton, @bbondy /cc @bradleyrichter Fix #5431 Fix #6511
Auditors: @bsclifton, @bbondy /cc @bradleyrichter Fix #5431 Fix #6511
Auditors: @bsclifton, @bbondy /cc @bradleyrichter Fix #5431 Fix #6511
Reopening based on the feedback by @srirambv and me.
Another adjustment of min-threshold for closeTab would be needed. |
@cezaraugusto I like your last solution quite well 💯 The next step is to fix #2702. |
Test plan
Under "QA steps" on #7799 (comment)
#7851 (comment)
Describe the issue you encountered: if you click the close button of tab whose size is too small, sometimes you click the close button accidently.
Expected behavior: Disable close button on tabs if tab size is too small.
Platform (Win7, 8, 10? macOS? Linux distro?): Windows 10
Brave Version: 0.12.8 RC1
Steps to reproduce:
Screenshot if needed:
The text was updated successfully, but these errors were encountered: