This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Remove tab icons for about:newtab and about:blank #5845
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -i
to squash commits (if needed).After tweaking the UI for tabs with no icon, it also addressed a fix for #5431
Fix #5776
Fix #5431
Auditors: @bsclifton
/cc @BradRichter could you checkout and see if the fix included here for #5431 fits our need?
Screenshot for #5431:
Test Plan (#5776):
npm run test -- --grep="tabs with icons"
Manual test (Test Plan for #5431):