Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Added "Save my downloads here" setting #2110

Closed
bradleyrichter opened this issue Jun 7, 2016 · 4 comments
Closed

Added "Save my downloads here" setting #2110

bradleyrichter opened this issue Jun 7, 2016 · 4 comments
Assignees
@NejcZdovc
Labels
documentation ✍ feature/download QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include settings
Milestone
0.14.0

Comments

@bradleyrichter
Copy link
Contributor

bradleyrichter commented Jun 7, 2016 •
edited by luixxiul
Loading

Test plan

#7023 (comment)

Functionality:
Providing a user-definable default downloads destination allows for a more efficient user work flow when downloading files. The default path is their downloads folder. This path can be changed by clicking on the pencil (edit) button. This opens a download location chooser dialog which is OS specific.

A toggle switch (off by default) allows the user to change the setting to ask them for the desired location upon each file download.

item label:
"Save my downloads here"

toggle switch label:
"Always ask me where to save files"

Download location sheet-dialog in Mac:
image

Spec image: (this issue in blue)
image
@bradleyrichter bradleyrichter added this to the 0.11.0dev milestone Jun 7, 2016
@bbondy bbondy modified the milestone: 0.11.1dev Jul 11, 2016
@bradleyrichter bradleyrichter mentioned this issue Nov 11, 2016
Closed
@luixxiul luixxiul added this to the 1.0.0 milestone Dec 25, 2016
@NejcZdovc
Copy link
Contributor

NejcZdovc commented Feb 3, 2017 •
edited
Loading

It's really annoying not having this and selecting folder for every single download. Will add this 😃

@NejcZdovc NejcZdovc self-assigned this Feb 3, 2017
@bradleyrichter
Copy link
Contributor Author

bradleyrichter commented Feb 3, 2017 via email

NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Feb 3, 2017
@NejcZdovc
Added default download path
4aebac9 
Resolves brave#2110

Auditors: @bradleyrichter @bsclifton

Test Plan:
- go to preferences, general tab
- define your default download path
- toggle show dialog
- based on your settings, download dialog should be opened or not
- if you set don't show dialog, filse should be downloaded to your default set path
@NejcZdovc NejcZdovc modified the milestones: 0.13.3, 1.0.0 Feb 3, 2017
@NejcZdovc NejcZdovc mentioned this issue Feb 3, 2017
Merged
4 tasks
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Feb 3, 2017
@NejcZdovc
Added default download path
4ac876a 
Resolves brave#2110

Auditors: @bradleyrichter @bsclifton

Test Plan:
- go to preferences, general tab
- define your default download path
- toggle show dialog
- based on your settings, download dialog should be opened or not
- if you set don't show dialog, filse should be downloaded to your default set path
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Feb 12, 2017
@NejcZdovc
Added default download path
b728e2b 
Resolves brave#2110

Auditors: @bradleyrichter @bsclifton

Test Plan:
- go to preferences, general tab
- define your default download path
- toggle show dialog
- based on your settings, download dialog should be opened or not
- if you set don't show dialog, filse should be downloaded to your default set path
@bbondy bbondy modified the milestones: 0.13.6, 0.13.5 Feb 16, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Feb 27, 2017
@NejcZdovc
Added default download path
d29fc95 
Resolves brave#2110

Auditors: @bradleyrichter @bsclifton

Test Plan:
- go to preferences, general tab
- define your default download path
- toggle show dialog
- based on your settings, download dialog should be opened or not
- if you set don't show dialog, filse should be downloaded to your default set path
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Mar 3, 2017
@NejcZdovc
Added default download path
c9da0ab 
Resolves brave#2110

Auditors: @bradleyrichter @bsclifton

Test Plan:
- go to preferences, general tab
- define your default download path
- toggle show dialog
- based on your settings, download dialog should be opened or not
- if you set don't show dialog, filse should be downloaded to your default set path
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Mar 3, 2017
@NejcZdovc
Added default download path
58a6fe6 
Resolves brave#2110

Auditors: @bradleyrichter @bsclifton

Test Plan:
- go to preferences, general tab
- define your default download path
- toggle show dialog
- based on your settings, download dialog should be opened or not
- if you set don't show dialog, filse should be downloaded to your default set path
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Mar 8, 2017
@NejcZdovc
Added default download path
a383e96 
Resolves brave#2110

Auditors: @bradleyrichter @bsclifton

Test Plan:
- go to preferences, general tab
- define your default download path
- toggle show dialog
- based on your settings, download dialog should be opened or not
- if you set don't show dialog, filse should be downloaded to your default set path

 # Added hover effect
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Mar 10, 2017
@NejcZdovc
Added default download path
c835413 
Resolves brave#2110

Auditors: @bradleyrichter @bsclifton

Test Plan:
- go to preferences, general tab
- define your default download path
- toggle show dialog
- based on your settings, download dialog should be opened or not
- if you set don't show dialog, filse should be downloaded to your default set path

 # Added hover effect
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Mar 13, 2017
@NejcZdovc
Added default download path
70b9f1d 
Resolves brave#2110

Auditors: @bradleyrichter @bsclifton

Test Plan:
- go to preferences, general tab
- define your default download path
- toggle show dialog
- based on your settings, download dialog should be opened or not
- if you set don't show dialog, filse should be downloaded to your default set path

 # Added hover effect
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Mar 13, 2017
@NejcZdovc
Added default download path
0488a54 
Resolves brave#2110

Auditors: @bradleyrichter @bsclifton

Test Plan:
- go to preferences, general tab
- define your default download path
- toggle show dialog
- based on your settings, download dialog should be opened or not
- if you set don't show dialog, filse should be downloaded to your default set path

 # Added hover effect
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Mar 13, 2017
@NejcZdovc
Added default download path
d3881eb 
Resolves brave#2110

Auditors: @bradleyrichter @bsclifton

Test Plan:
- go to preferences, general tab
- define your default download path
- toggle show dialog
- based on your settings, download dialog should be opened or not
- if you set don't show dialog, filse should be downloaded to your default set path

 # Added hover effect
@alexwykoff alexwykoff mentioned this issue Mar 14, 2017
Closed
44 tasks
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Mar 16, 2017
@NejcZdovc
Added default download path
88b44fd 
Resolves brave#2110

Auditors: @bradleyrichter @bsclifton

Test Plan:
- go to preferences, general tab
- define your default download path
- toggle show dialog
- based on your settings, download dialog should be opened or not
- if you set don't show dialog, filse should be downloaded to your default set path

 # Added hover effect
bsclifton added a commit that referenced this issue Mar 16, 2017
@bsclifton
Merge pull request #7023 from NejcZdovc/feature/#2110-download
2faf7e9 
Added default download path
This was referenced Mar 17, 2017
Closed
Closed
Closed
Closed
Closed
@luixxiul luixxiul mentioned this issue Mar 17, 2017
Closed
@alexwykoff alexwykoff mentioned this issue Mar 21, 2017
Closed
@cndouglas
Copy link

A toggle switch (off by default) allows the user to change the setting to ask them for the desired location upon each file download.

This is what I get on a fresh install:
image
Should the switch be on or off by default?

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Mar 24, 2017 •
edited
Loading

I set it to on by default yes. If we go with the off by default, then I think we would need to set default path when browser is first lunched (or when you go to preferences, we use same function for path determination that we use it on the save event), otherwise it would be strange to have empty input and option to off

cc @bradleyrichter

@alexwykoff alexwykoff changed the title General Settings: "Save my downloads here" setting Added "Save my downloads here" setting Mar 28, 2017
This was referenced Mar 28, 2017
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
documentation ✍ feature/download QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include settings
Projects
None yet
Milestone
0.14.0
Development

No branches or pull requests
7 participants
@bbondy @alexwykoff @luixxiul @NejcZdovc @bradleyrichter @srirambv @cndouglas