This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 973
Downloading the same name file disabling the save file dialog should change the filename #7764
Labels
Milestone
Comments
I think that this should be handled on Muon part cc @bridiver |
I ran into this today. Please fix! This bug scares me. |
timborden
added a commit
to timborden/browser-laptop
that referenced
this issue
Jul 5, 2017
8 tasks
Hey @luixxiul & @NejcZdovc, I just submitted a PR (#9867) for this issue |
timborden
added a commit
to timborden/browser-laptop
that referenced
this issue
Jul 5, 2017
timborden
added a commit
to timborden/browser-laptop
that referenced
this issue
Jul 6, 2017
timborden
added a commit
to timborden/browser-laptop
that referenced
this issue
Jul 11, 2017
timborden
added a commit
to timborden/browser-laptop
that referenced
this issue
Jul 11, 2017
Hey @luixxiul & @NejcZdovc, I've updated the PR based on the feedback from @bridiver and added some tests as well....FYI |
timborden
added a commit
to timborden/browser-laptop
that referenced
this issue
Aug 9, 2017
dfperry5
pushed a commit
to dfperry5/browser-laptop
that referenced
this issue
Aug 18, 2017
This was referenced Dec 20, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Test plan
#9867 (comment)
Describe the issue you encountered:
Downloading the same name file disabling the save file dialog should change the filename, like Edge does. For now the file is overwritten, which users do not always want to see.
Platform (Win7, 8, 10? macOS? Linux distro?):
Brave Version (revision SHA): 0.14.0 Preview
Steps to reproduce:
Actual result: the file is overwritten
Expected result: the file should be saved with the filename changed, eg RELEASES-ia32(1)
Any related issues: Added "Save my downloads here" setting #2110
Marking this with impact/high as the users could lose their files by accident because of this setting, which behaves slightly different than the other browsers.
The text was updated successfully, but these errors were encountered: