Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

document.l10n is sometimes undefined #6012

Closed
bridiver opened this issue Dec 4, 2016 · 1 comment · Fixed by #6013
Closed

document.l10n is sometimes undefined #6012

bridiver opened this issue Dec 4, 2016 · 1 comment · Fixed by #6013
Labels
QA/no-qa-needed release-notes/include
Milestone
0.13.0

Comments

@bridiver
Copy link
Collaborator

bridiver commented Dec 4, 2016

document.l10n is accessed in about pages, but it is loaded after the script and can be missing when it is checked
bridiver added a commit that referenced this issue Dec 4, 2016
@bridiver
cleanup about page handling and fix missing document.l10n
71b815b 
fixes #6012
@bridiver bridiver mentioned this issue Dec 4, 2016
Merged
4 tasks
bbondy pushed a commit that referenced this issue Dec 4, 2016
@bridiver @bbondy
cleanup about page handling and fix missing document.l10n
44c9e19 
fixes #6012
@bbondy bbondy reopened this Dec 5, 2016
@cndouglas
Copy link

#6013 (comment):

Sorry I had to back this out because it was causing development builds to not see changes. webpack-dev-server doesn't know about gen.

@bbondy bbondy closed this as completed in d82cb2a Dec 7, 2016
@bbondy bbondy added this to the 0.13.0 milestone Dec 7, 2016
This was referenced Dec 20, 2016
Closed
Closed
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
QA/no-qa-needed release-notes/include
Projects
None yet
Milestone
0.13.0
Development

Successfully merging a pull request may close this issue.

cleanup about page handling and fix missing document.l10n brave/browser-laptop
4 participants
@bridiver @bbondy @luixxiul @cndouglas