Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

cleanup about page handling and fix missing document.l10n #6013

Merged
merged 1 commit into from
Dec 4, 2016

Conversation

bridiver
Copy link
Collaborator

@bridiver bridiver commented Dec 4, 2016

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

fixes #6012

Test Plan:
For each about page:

  1. Load the page
  2. Ensure that the page and favicon load correctly

@bridiver
Copy link
Collaborator Author

bridiver commented Dec 4, 2016

@bbondy @bsclifton

@bsclifton
Copy link
Member

++ I like this 😎

@bbondy
Copy link
Member

bbondy commented Dec 4, 2016

++

@bbondy
Copy link
Member

bbondy commented Dec 5, 2016

Sorry I had to back this out because it was causing development builds to not see changes. webpack-dev-server doesn't know about gen.

@bridiver
Copy link
Collaborator Author

bridiver commented Dec 7, 2016

@bbondy gen is also the path for the webpack dev server. The change to the filtering code sends it to localhost or the file path depending on the env. I tested it and didn't see any problems, can you give me a specific example of something that didn't update?

@bridiver
Copy link
Collaborator Author

bridiver commented Dec 7, 2016

I just rebased it and tested updating preferences.js (for about pages) and main.js (for the main window) and both reloaded automatically

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

document.l10n is sometimes undefined
4 participants