Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Payment history footer message needs correct past/future context #6059

Closed
bradleyrichter opened this issue Dec 7, 2016 · 5 comments
Closed

Payment history footer message needs correct past/future context #6059

bradleyrichter opened this issue Dec 7, 2016 · 5 comments
Assignees
@bsclifton
Labels
bug feature/rewards QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.13.2

Comments

@bradleyrichter
Copy link
Contributor

bradleyrichter commented Dec 7, 2016 •
edited by luixxiul
Loading

problem: (your next contribution is 6 days ago)

image

code point:

browser-laptop/js/about/preferences.js

Line 963 in d86d963

get paymentHistoryFooter () {

Test Plan

  1. ensure that reconcileStamp in ledger-state.json is in the future - the message in about:preferences#payments should show a future contribution.

  2. set reconcileStamp to less than a day in the past - the message should indicate today.

  3. set reconcileStamp to more than a day in the past - the message should indicate overdue.
@bradleyrichter bradleyrichter modified the milestones: 0.13.3, 0.13.1 Dec 7, 2016
This was referenced Dec 7, 2016
Closed
Merged
bkilrain added a commit to bkilrain/browser-laptop that referenced this issue Jan 13, 2017
@bkilrain
Change payment history footer verb tense
303744f 
This commit changes the tense of the payment history footer from present tense
to past tense.

Fix brave#6059

Auditors: @bsclifton

Test Plan: n/a
bkilrain added a commit to bkilrain/browser-laptop that referenced this issue Jan 13, 2017
@bkilrain
Change paymentHistoryFooter verb tense
2c78241 
This commit changes the paymentHistoryFooter text to match the fact that
reconcileDate will always be in the past (it is generated from moment.js's
fromNow() method).

Fixes brave#6059

Auditors: @bsclifton

Tests: n/a
@bkilrain bkilrain mentioned this issue Jan 13, 2017
Closed
4 tasks
@bkilrain
Copy link
Contributor

bkilrain commented Jan 13, 2017 •
edited
Loading

@bsclifton Hi there - I took it upon myself to give this one a try. I've poked through the codebase and it seems that paymentHistoryFooter should always refer to an action in the past (it's the history). So I just adjusted the language to reflect that.

mrose17 added a commit that referenced this issue Jan 20, 2017
@mrose17
0.13.1: Payment history footer message needs correct past/future context
f660a9e 
Fixes #6059
@mrose17 mrose17 mentioned this issue Jan 20, 2017
Closed
@luixxiul
Copy link
Contributor

luixxiul commented Jan 20, 2017 •
edited
Loading

@bkilrain @mrose17 Is #6628 replaced with #6766?

@mrose17
Copy link
Member

mrose17 commented Jan 20, 2017

@luixxiul - i didn't see that PR, @bkardell - sorry!

@luixxiul - the code in #6766 is what we want because it handles each of the past/present/future cases, so #6628 should be closed without being merged...

@bsclifton
Copy link
Member

cc: the original contributor for #6628 @bkilrain (whose handle was accidentally typo'ed as @bkardell). Lots of Brians in here! ❤️

@luixxiul
Copy link
Contributor

@bkilrain sorry for typo...

@mrose17 mrose17 mentioned this issue Jan 24, 2017
Merged
This was referenced Feb 3, 2017
Closed
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bsclifton bsclifton

Labels
bug feature/rewards QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.13.2
Development

No branches or pull requests
6 participants
@mrose17 @luixxiul @bsclifton @bradleyrichter @srirambv @bkilrain