This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
0.13.1: Payment history footer message needs correct past/future context #6766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves #6402 Auditors: @bsclifton Test Plan: -Go to link in the issue -Select link -Right click on text selection -Context menu for link should appear
Fix #6217 Auditors: @bsclifton
Considering the context menus disappear on the mousedown event I added hamburgerMenuWasOpen to the windowState to be able to check it when the hamburgerMenu's onClick is executed Closes #4921
The added tests test that the hamburgerMenu's context menu appears, disappears, reappears on different clicks
Fixes ##5828 Auditors: @bsclifton @echosa Test Plan: - Build brave - Open local file with brave (double click) - Local file should be opened
Deletes "Report an Issue" menu item because both it and "Submit Feedback" link to community.brave.com. Resolves #6180
Resolves #6180 Auditors: Test Plan:
The cert fingerprint emitted by Muon/Electron is base64 encoded [1], so it may contain '/'. I think we were truncating the certificate fingerprint when this was the case, which may have caused the decoding error in #6524. [1] https://cs.chromium.org/chromium/src/net/base/hash_value.h?q=net::HashValue&sq=package:chromium&l=58 Auditors: @darkdh
Resolves #1302 Auditors: @bsclifton Test Plan: - go to website with a form - submit form so that autofill will be triggered - go to the same website and double click on the input to trigger autofill - use down arrow to select value and press enter - value should be field into the input
Majorly, the change affects 2 places in the UI. The Clear Browsing Data… option in the History menu and the Clear Browsing Data Now… button in the Security tab in Preferences. We store the state of the toggled options when the user clears anytime, so that the next time he/she opens this dialog, the options are pre-populated as per the last selected options From a technical perspective, we have moved away from saving the current state of the SwitchControls in the windowState. We only save the visibility on the windowState. The whole state is managed by the panel itself and just updates the appState on clicking clear. Fixes #4082
fix #6540 Auditors: @diracdeltas Test Plan: 1. Go to http://xn--jp%29-5y3b.f1-live.com/f1/jp/headlines/news/detail/060912193351.shtml 2. There should be a DNS error page
Auditor: @bsclifton, @darkdh Fix #6160 Test plan: Automated tests must pass npm run test -- --grep="returns newSiteDetail value for lastAccessedTime when oldSite value is undefined" npm run test -- --grep="returns oldSiteDetail value for lastAccessedTime when newSite value is undefined"
(opens a file chooser dialog) fixes #4806 Includes tests for Ledger backup and recovery: - add advanced ledger panel tests file `test/components/ledgerPanelAdvancedPanelTest.js` - add tests for backup and recovery of wallet - add commands to Brave test client (`ipcOnce`, `ipcSendRendererSync`, and `translations`) client.translations: returns a map of all existing translations (current locale) to test client Import recovery keys success closes modals - successful import closes modals - and closing file chooser dialog does not trigger error screen fixes #6263 Import recovery keys shows error popover if keys are invalid or missing - error popover is displayed if paymentId / passphrase are missing or not UUIDs (ledger-client#recoverWallet should probably do validation too) - added tests for cases: one or both recovery keys missing from file a recovery key is not a UUID an empty recovery file
Reverted "viewPaymentHistory" back to original text Auditors: @mrose17
- Added comments inside .paymentsContainer on preferences.less - Replaced variables inside it - Fixed regressions Auditors: @bsclifton @jkup Test Plan: 1. Find .paymentsContainer inside preferences.less 2. Correct my unsophisticated expressions ;-) 3. Make sure the style of about:preferences#payments does not regress
Close #6261 Auditors: @mrose17, @bsclifton
Allow the search icon to show while loading. This removes a display lag time for URL bar icons. Fixes #6518.
I missed this with #6319 but our tests caught it :) Auditors: @gyandeeps
Also fixes #6551 of the “sonorous seven”
To avoid currency exchange “jitter”. Partially address #6707
|
Did something previously land that manually modifies them?No code at all should change in those files. There is no point to have a changelog history item for any changes there as they'll be supplanted by safe copies. |
|
In particular for code inside |
bsclifton
force-pushed
the
0.13.1-branch
branch
2 times, most recently
from
aceaf39 to
8190b88
Compare
|
Obsoleted by #6839 |
bsclifton
pushed a commit
that referenced
this pull request
Jan 26, 2017
…t/future context Rework of #6766
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6059
Auditor: @bsclifton
Test Plan:
ensure that
reconcileStampinledger-state.jsonis in the future - the message in about:preferences#payments should show a future contribution.set
reconcileStampto less than a day in the past - the message should indicate today.set
reconcileStampto more than a day in the past - the message should indicate overdue.