Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Save recovery file opens new tab #7511

Closed
NejcZdovc opened this issue Mar 6, 2017 · 4 comments
Closed

Save recovery file opens new tab #7511

NejcZdovc opened this issue Mar 6, 2017 · 4 comments
Assignees
@NejcZdovc
Labels
bug design A design change, especially one which needs input from the design team. feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.22.x (Release C...

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Mar 6, 2017 •
edited by srirambv
Loading

Testplan

see #13279

  • Did you search for similar issues before submitting this one?
    yes

  • Describe the issue you encountered:
    When you click on Save recovery file... in overlay Backup your Brave wallet, new tab is opened after save or cancel.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    macOS

  • Brave Version (revision SHA):
    72c0293

  • Steps to reproduce:

    1. Go to payments and try to back your wallet
    2. Click on Save recovery file
    3. Click cancel
    4. New tab is opened with a content of the backup file

  • Actual result:
    New tab is opened

  • Expected result:
    New tab shouldn't be opened

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    yes

  • Is this an issue in the currently released version?
    yes

  • Can this issue be consistently reproduced?
    yes
@mrose17 mrose17 added this to the 0.13.6 milestone Mar 7, 2017
@bsclifton
Copy link
Member

Moving to 0.13.7

@bsclifton bsclifton modified the milestones: 0.13.7, 0.13.6 Mar 13, 2017
@bsclifton bsclifton modified the milestones: 0.14.2, 0.14.1 Mar 29, 2017
@bsclifton
Copy link
Member

moving to 0.14.2

@bsclifton bsclifton added needs-owner ♞ This issue is tagged for an upcoming release but has no owner. and removed needs-owner ♞ This issue is tagged for an upcoming release but has no owner. labels Apr 4, 2017
@alexwykoff alexwykoff added the design A design change, especially one which needs input from the design team. label Apr 18, 2017
@alexwykoff
Copy link
Contributor

Hey @bradleyrichter we need you to weigh in on this since I would say that it's fine to open a new tab. :)

@alexwykoff alexwykoff modified the milestones: 1.0.0, 0.15.1 Apr 18, 2017
@ghost ghost removed this from the 1.0.0 milestone Sep 26, 2017
@bsclifton bsclifton added this to the Triage Backlog milestone Nov 27, 2017
@NejcZdovc NejcZdovc added the needs-info Another team member needs information from the PR/issue opener. label Jan 17, 2018
@NejcZdovc NejcZdovc modified the milestones: Triage Backlog, 0.21.x (Beta Channel) Feb 23, 2018
@NejcZdovc NejcZdovc mentioned this issue Feb 23, 2018
Merged
10 tasks
@NejcZdovc NejcZdovc removed needs-info Another team member needs information from the PR/issue opener. needs-owner ♞ This issue is tagged for an upcoming release but has no owner. labels Feb 23, 2018
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Feb 23, 2018
@NejcZdovc
Fixes backup keys export/import; improves print flow
6c186ec 
Resolves brave#13274
Resolves brave#7512
Resolves brave#7511
Resolves brave#11419

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Feb 23, 2018
@NejcZdovc
Fixes backup keys export/import; improves print flow
06e0ad2 
Resolves brave#13274
Resolves brave#7512
Resolves brave#7511
Resolves brave#11419

Auditors:

Test Plan:
This was referenced Mar 22, 2018
Closed
Closed
@LaurenWags
Copy link
Member

LaurenWags commented Mar 22, 2018 •
edited by btlechowski
Loading

Verified on macOS 10.12.6 x64 using the following build:

  • 0.22.6 e6ff4ea
  • libchromiumcontent: 65.0.3325.162
  • muon: 5.1.0

Verified on Ubuntu 10.10 x64

  • 0.22.7 8bb7e77
  • libchromiumcontent: 65.0.3325.181
  • muon: 5.1.1

@kjozwiak kjozwiak mentioned this issue Mar 29, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
bug design A design change, especially one which needs input from the design team. feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.22.x (Release Channel)
Development

No branches or pull requests
9 participants
@mrose17 @petemill @alexwykoff @bsclifton @NejcZdovc @bradleyrichter @srirambv @LaurenWags @btlechowski