This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 972
Fixes backup keys export/import; improves print flow #13279
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NejcZdovc
force-pushed
the
hotfix/#13274-dialog
branch
from
February 23, 2018 15:08
c4e2d02
to
6c186ec
Compare
Resolves brave#13274 Resolves brave#7512 Resolves brave#7511 Resolves brave#11419 Auditors: Test Plan:
NejcZdovc
force-pushed
the
hotfix/#13274-dialog
branch
from
February 23, 2018 15:14
6c186ec
to
06e0ad2
Compare
Codecov Report
@@ Coverage Diff @@
## master #13279 +/- ##
==========================================
+ Coverage 56.06% 56.07% +<.01%
==========================================
Files 282 282
Lines 28060 28075 +15
Branches 4607 4611 +4
==========================================
+ Hits 15732 15742 +10
- Misses 12328 12333 +5
|
@NejcZdovc for test plan C, should the backup codes be bold ? |
@srirambv yes, I changed that so that you can see them easily |
srirambv
approved these changes
Feb 26, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ manually tested and works fine.
bsclifton
approved these changes
Mar 2, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cherry-picked into 0.22.x and verified all test plans 😄
Really nice set of fixes here- print worked great, it's nice not having a new tab open for the key (not to mention, not storing the backup in the profile dir). Great job 😻
bsclifton
added a commit
that referenced
this pull request
Mar 2, 2018
Fixes backup keys export/import; improves print flow
bsclifton
added a commit
that referenced
this pull request
Mar 2, 2018
Fixes backup keys export/import; improves print flow
10 tasks
This was referenced Mar 21, 2018
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #13274
Resolves #7512
Resolves #7511
Resolves #11419
Submitter Checklist:
git rebase -i
to squash commits (if needed).Test Plan:
Plan a (#13274)
Plan b (#13274)
Plan c (#7512)
Plan d (#7511)
Plan e (#11419)
brave_wallet_recovery.txt
is not thereReviewer Checklist:
Tests