Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixes backup keys export/import; improves print flow #13279

Merged
merged 1 commit into from
Mar 2, 2018

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Feb 23, 2018

Resolves #13274
Resolves #7512
Resolves #7511
Resolves #11419

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed. (Ask a Brave employee to help if you cannot access this document.)

Test Plan:

Plan a (#13274)

  1. Enable payments
  2. Go to advance settings
  3. Export backup keys

Plan b (#13274)

  1. Enable payments
  2. Go to advance settings
  3. Import backup keys

Plan c (#7512)

  1. Enable payments
  2. Go to advance settings
  3. Go to backup
  4. Click print
  5. Make sure that new tab is opened and print dialog is shown

Plan d (#7511)

  1. Enable payments
  2. Go to advance settings
  3. Export backup keys
  4. Make sure that new tab is not opened

Plan e (#11419)

  1. Enable payments
  2. Go to advance settings
  3. Export backup keys
  4. Go to brave profile folder and make sure that brave_wallet_recovery.txt is not there

Reviewer Checklist:

  • Request a security/privacy review as needed if one was not already requested.

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@NejcZdovc NejcZdovc added this to the 0.21.x (Beta Channel) milestone Feb 23, 2018
@NejcZdovc NejcZdovc self-assigned this Feb 23, 2018
@NejcZdovc NejcZdovc force-pushed the hotfix/#13274-dialog branch from c4e2d02 to 6c186ec Compare February 23, 2018 15:08
@NejcZdovc NejcZdovc force-pushed the hotfix/#13274-dialog branch from 6c186ec to 06e0ad2 Compare February 23, 2018 15:14
@codecov-io
Copy link

codecov-io commented Feb 23, 2018

Codecov Report

Merging #13279 into master will increase coverage by <.01%.
The diff coverage is 18.6%.

@@            Coverage Diff             @@
##           master   #13279      +/-   ##
==========================================
+ Coverage   56.06%   56.07%   +<.01%     
==========================================
  Files         282      282              
  Lines       28060    28075      +15     
  Branches     4607     4611       +4     
==========================================
+ Hits        15732    15742      +10     
- Misses      12328    12333       +5
Flag Coverage Δ
#unittest 56.07% <18.6%> (ø) ⬆️
Impacted Files Coverage Δ
js/constants/messages.js 100% <ø> (ø) ⬆️
js/constants/appConstants.js 100% <ø> (ø) ⬆️
js/actions/appActions.js 18.69% <0%> (-0.11%) ⬇️
app/browser/tabs.js 23.78% <0%> (-0.12%) ⬇️
js/lib/appUrlUtil.js 86.53% <100%> (ø) ⬆️
app/browser/api/ledger.js 58.64% <12.5%> (-0.04%) ⬇️
app/browser/reducers/ledgerReducer.js 43.71% <75%> (-0.45%) ⬇️
...r/components/preferences/payment/ledgerRecovery.js 37.25% <0%> (-0.75%) ⬇️
... and 4 more

@srirambv
Copy link
Collaborator

srirambv commented Feb 26, 2018

@NejcZdovc for test plan C, should the backup codes be bold ?
image

@NejcZdovc
Copy link
Contributor Author

@srirambv yes, I changed that so that you can see them easily

Copy link
Collaborator

@srirambv srirambv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ manually tested and works fine.

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cherry-picked into 0.22.x and verified all test plans 😄

Really nice set of fixes here- print worked great, it's nice not having a new tab open for the key (not to mention, not storing the backup in the profile dir). Great job 😻

@bsclifton bsclifton merged commit 7c2cf6d into brave:master Mar 2, 2018
bsclifton added a commit that referenced this pull request Mar 2, 2018
Fixes backup keys export/import; improves print flow
bsclifton added a commit that referenced this pull request Mar 2, 2018
Fixes backup keys export/import; improves print flow
@bsclifton
Copy link
Member

master 7c2cf6d
0.23.x e8fc619
0.22.x b39d39e

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants