Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Insecure connection info shown for about pages and new tab #8299

Closed
srirambv opened this issue Apr 13, 2017 · 0 comments · Fixed by #8542
Closed

Insecure connection info shown for about pages and new tab #8299

srirambv opened this issue Apr 13, 2017 · 0 comments · Fixed by #8542

Comments

@srirambv
Copy link
Collaborator

srirambv commented Apr 13, 2017

Test plan

6a9b7f6


  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    With connection info modal opened on a site pressing Ctrl +
    Tab, shows insecure connection info shown for about pages and new tab

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    All

  • Brave Version (revision SHA):
    Brave 0.14.2
    rev f07c142

  • Steps to reproduce:

    1. Visit any site in a new tab
    2. Open any about page and a new tab
    3. Click and view the connection info on the site visited in step1
    4. Press Ctrl+Tab to cycle through the tabs with the connection info modal open
    5. About page and new tab also shows as Using insecure connection
  • Actual result:
    Insecure connection info shown for about pages and new tab

  • Expected result:
    Connection info modal should be dismissed when Ctrl+Tab is pressed

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    Pretty sure its the same from begining

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:
    connectioninfo

  • Any related issues:
    cc: @diracdeltas @bsclifton

@srirambv srirambv added bug design A design change, especially one which needs input from the design team. labels Apr 13, 2017
@srirambv srirambv added this to the 0.14.3 milestone Apr 13, 2017
@diracdeltas diracdeltas self-assigned this Apr 13, 2017
diracdeltas added a commit that referenced this issue Apr 27, 2017
fix #8299

Test Plan:
1. open example.com
2. open a new tab
3. show siteInfo on example.com, then use Cmd+2 to switch to the second tab
4. no siteInfo should show on the second tab
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants