Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

show nothing for siteInfo on about: pages #8542

Merged
merged 1 commit into from
Apr 28, 2017
Merged

show nothing for siteInfo on about: pages #8542

merged 1 commit into from
Apr 28, 2017

Conversation

diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented Apr 27, 2017

fix #8299

Test Plan:

  1. open example.com
  2. open a new tab
  3. show siteInfo on example.com, then use Cmd+2 to switch to the second tab
  4. no siteInfo should show on the second tab
  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

Test Plan:

fix #8299

Test Plan:
1. open example.com
2. open a new tab
3. show siteInfo on example.com, then use Cmd+2 to switch to the second tab
4. no siteInfo should show on the second tab
@diracdeltas diracdeltas requested a review from darkdh April 27, 2017 23:57
@diracdeltas diracdeltas added this to the 0.15.1 milestone Apr 27, 2017
Copy link
Member

@darkdh darkdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm++

@diracdeltas diracdeltas merged commit c88f470 into master Apr 28, 2017
@bsclifton bsclifton deleted the fix/8299 branch May 22, 2017 16:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Insecure connection info shown for about pages and new tab
3 participants