Production release should ignore NODE_ENV environment variable

[johanalkstal]

Having just downloaded the Win 64 installer and finished installing, this is what I'm greeted with.

[bbondy]

where did you download from?

[johanalkstal]

I tried both from the in-mail link and from brave.com front page link.

[bbondy]

have you ever had the development version installed?

[johanalkstal]

No first time installing Brave on Windows.

[bbondy]

Do you have NOD_ENV set globally as an environment variable?

[johanalkstal]

That I do.

[bbondy]

bingo! OK we should change this, thanks for the post. For now you can set it not globally only on your project that needs it.

[johanalkstal]

Indeed. I think that is good advice overall. :)

[bbondy]

haven't had time to do this yet, moving to 0.8.1

[luixxiul]

Does we need to work on this at all?

[bbondy]

yes we should still fix, I haven't heard of more people affected yet though so not the highest priority.

[bsclifton]

Reworded issue-
Our production builds should not be considering the NODE_ENV environment variable

[jonathansampson]

@bbondy @bsclifton I just got off a call with a user who ran into this; removing the node_env value resolved the issue for them.

[bsclifton]

@jonathansampson this could be a tricky one to solve properly... I think it's safe to say this wouldn't affect most users. Maybe we could describe the symptoms and share the fix on community.brave.com?

[jonathansampson]

@bsclifton Yeah, I suspect this is only going to impact developers (unless some software sets the same environment variable). One developer with whom I spoke wasn't familiar with env-variables, and still had this one set (which makes me wonder if some software may have set it).

[NejcZdovc]

@jonathansampson @bsclifton because this behaviour is meant for developers only, we can detect if you set it and display notification on lunch with steps how to remove it. wdyt?

[bsclifton]

I think if a contributor wanted to grab this, we can help them come up with messaging... but I think it's fairly low priority. Definitely won't be a problem with Brave Core

[bsclifton]

This will no longer be an issue once we move to brave-core