Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

added emoji-regex in package.json, modified urlBar.js to remove emoji #10276

Closed
wants to merge 0 commits into from

Conversation

prasanthp96
Copy link
Contributor

@prasanthp96 prasanthp96 commented Aug 3, 2017

Fixes #10051

As per the hint given, I have removed the emojis in title bar by using emoji-regex and replacing them with empty string.

brave

Reviewer Tag:
@cezaraugusto

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@cezaraugusto
Copy link
Contributor

sorry I was unable to add a test case and eventually closed this. I created #10314 keeping you as the committer. Looks perfect btw please follow there and sorry for the inconvenience :) great job

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants