This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
added emoji-regex in package.json, modified urlBar.js to remove emoji #10314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
|
@prasanthp96 sorry I had to re-open the PR and thanks for the quick follow. PR looks really good. Added a test to ensure it looks as great as you did for a long time :). btw congrats for your first contribution! 🎉 Looking forward for the next one. Feel free to hit me up over our Discourse channel (Brave Community) or twitter (same handler as GitHub) if you want to kill some more bugs. Merging. Onwards! |
|
Thanks for the patch, @prasanthp96 😄 👍 |
|
Happy that I have contributed to Brave browser. I will work on other bugs for sure @cezaraugusto . |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is the same as #10276 with original commit + a new test. I was unable to add a test to the fork but kept commit with original author.
Fix #10051
/cc @prasanthp96