Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fix #1848 (bookmark tooltips) #1926

Merged
merged 1 commit into from
May 29, 2016
Merged

Fix #1848 (bookmark tooltips) #1926

merged 1 commit into from
May 29, 2016

Conversation

cndouglas
Copy link

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Ran git rebase -i to squash commits if needed.

Adds a tooltip that shows the bookmark's title and URL.

Fixes #1848 (URL tooltip for items on bookmarks toolbar).

@cndouglas
Copy link
Author

cndouglas commented May 26, 2016

My sincere apologies for the mess. I am definitely a Javascript and git/GitHub noob.

@bsclifton
Copy link
Member

bsclifton commented May 28, 2016

The newline in here isn't working (at least on Windows)
2016-05-28

I wonder if there's a better way to do it. But regardless, this will be a cool change 😄

@cndouglas
Copy link
Author

Maybe \r\n should be used instead.

@bsclifton
Copy link
Member

bsclifton commented May 28, 2016

\n works great 😄
2016-05-28 1

title={this.isFolder ? '' : this.props.bookmark.get('title') + '\n' + this.props.bookmark.get('location')}

Can you try changing it to that on your platform? If it looks good, please commit and we can merge

@cndouglas
Copy link
Author

The pull request has been updated to use \n. (yay, I finally figured out how to squash commits!)

@bsclifton
Copy link
Member

Looks great, thanks again! 😄

@bsclifton bsclifton merged commit 8d7df42 into brave:master May 29, 2016
@luixxiul luixxiul added this to the 0.10.1dev milestone May 29, 2016
@bbondy
Copy link
Member

bbondy commented May 29, 2016

++

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants