Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add new "empty new tab" option in preferences (for what new tab does) #5690

Merged
merged 3 commits into from
Nov 22, 2016
Merged

Add new "empty new tab" option in preferences (for what new tab does) #5690

merged 3 commits into from
Nov 22, 2016

Commits on Nov 22, 2016

  1. Add new "empty new tab" option in preferences (for what new tab does) 

    *includes tests* :)

Fixes #5682

Please note: choosing this option does NOT put focus in the URL bar. Is this OK?
cc: @diracdeltas

Auditors: @bradleyrichter, @bbondy

Test Plan:
1. Launch Brave and go to preferences
2. Change "A new tab shows" to "empty new tab"
3. Open a new tab; notice it's about:blank
    @bsclifton
    bsclifton committed Nov 22, 2016
    Configuration menu
    Copy the full SHA
    7c3bd51 View commit details
    Browse the repository at this point in the history

  2. new naming for new tab page menus

    @bradleyrichter @bsclifton
    bradleyrichter authored and bsclifton committed Nov 22, 2016
    Configuration menu
    Copy the full SHA
    cee8499 View commit details
    Browse the repository at this point in the history

  3. Reworked new tab settings: 

    - if empty tab, about:newtab returns an empty div
- regardless of choice, page is about:newtab (not about:blank)
- tests added to reinforce this behavior

Auditors: @bbondy, @cezaraugusto
    @bsclifton
    bsclifton committed Nov 22, 2016
    Configuration menu
    Copy the full SHA
    af6a015 View commit details
    Browse the repository at this point in the history