Add new "empty new tab" option in preferences (for what new tab does)

app/common/constants/settingsEnums.js

@@ -11,7 +11,8 @@ const startsWithOption = {
 const newTabMode = {
   NEW_TAB_PAGE: 'newTabPage',
   HOMEPAGE: 'homePage',
-  DEFAULT_SEARCH_ENGINE: 'defaultSearchEngine'
+  DEFAULT_SEARCH_ENGINE: 'defaultSearchEngine',
+  EMPTY_NEW_TAB: 'emptyNewTab'
 }
 
 const bookmarksToolbarMode = {

app/extensions/brave/locales/en-US/preferences.properties

@@ -101,16 +101,17 @@ hint2=The File menu allows you to create a New Session Tab. Session tabs are lik
 sendUsFeedback=Send us feedback…
 loveToHear=We'd love to hear from you.
 startsWith=Brave starts with
-startsWithOptionLastTime=my windows / tabs from last time
-startsWithOptionHomePage=my home page
-startsWithOptionNewTabPage=the new tab page
+startsWithOptionLastTime=My windows / tabs from last time
+startsWithOptionHomePage=Home page
+startsWithOptionNewTabPage=Dashboard
 newTabMode=A new tab shows
 newTabBlank=blank
+newTabNewTabPage=Dashboard
+newTabHomePage=Home page
+newTabDefaultSearchEngine=Default search engine
+newTabEmpty=Blank page
+myHomepage=My home page is
 aboutBlank=about:blank
-newTabNewTabPage=the new tab page
-newTabHomePage=my home page
-newTabDefaultSearchEngine=default search engine
-myHomepage=My homepage is
 default=Default
 searchEngine=Search Engine
 engineGoKey=Engine Go Key (Type First)
@@ -217,7 +218,7 @@ downloadsLabel=Save my downloads here:
 downloadsInput=~/downloads/
 downloadsAskAlwaysSwitch=Always ask me where to save files
 notifyOnUpdate=Notify me when an update is available
-showHomeButton=Show Home button on URL bar
+showHomeButton=Show home button on URL bar
 mediaPermission=Camera and microphone access
 geolocationPermission=Location access
 notificationsPermission=Show notifications

js/about/newtab.js

@@ -7,7 +7,7 @@ const React = require('react')
 const Immutable = require('immutable')
 const messages = require('../constants/messages')
 const HTML5Backend = require('react-dnd-html5-backend')
-const { DragDropContext } = require('react-dnd')
+const {DragDropContext} = require('react-dnd')
 const Stats = require('./newTabComponents/stats')
 const Clock = require('./newTabComponents/clock')
 const Block = require('./newTabComponents/block')
@@ -32,7 +32,8 @@ class NewTabPage extends React.Component {
       showSiteRemovalNotification: false,
       backgroundImage: this.randomBackgroundImage,
       imageLoadFailed: false,
-      updatedStamp: undefined
+      updatedStamp: undefined,
+      showEmptyPage: true
     }
     ipc.on(messages.NEWTAB_DATA_UPDATED, (e, newTabData) => {
       const data = Immutable.fromJS(newTabData || {})
@@ -47,7 +48,8 @@ class NewTabPage extends React.Component {
 
       this.setState({
         newTabData: data,
-        updatedStamp: updatedStamp
+        updatedStamp: updatedStamp,
+        showEmptyPage: !!data.get('showEmptyPage')
       })
     })
   }
@@ -216,6 +218,10 @@ class NewTabPage extends React.Component {
   }
 
   render () {
+    // don't render if user prefers an empty page
+    if (this.state.showEmptyPage) {
+      return <div className='empty' />
+    }
     // don't render until object is found
     if (!this.state.newTabData) {
       return null

js/about/preferences.js

@@ -658,6 +658,7 @@ class GeneralTab extends ImmutableComponent {
             <option data-l10n-id='newTabNewTabPage' value={newTabMode.NEW_TAB_PAGE} />
             <option data-l10n-id='newTabHomePage' value={newTabMode.HOMEPAGE} />
             <option data-l10n-id='newTabDefaultSearchEngine' value={newTabMode.DEFAULT_SEARCH_ENGINE} />
+            <option data-l10n-id='newTabEmpty' value={newTabMode.EMPTY_NEW_TAB} />
           </select>
         </SettingItem>
         <SettingItem dataL10nId='myHomepage'>

js/components/frame.js

@@ -33,6 +33,7 @@ const currentWindow = require('../../app/renderer/currentWindow')
 const windowStore = require('../stores/windowStore')
 const appStoreRenderer = require('../stores/appStoreRenderer')
 const siteSettings = require('../state/siteSettings')
+const {newTabMode} = require('../../app/common/constants/settingsEnums')
 
 const WEBRTC_DEFAULT = 'default'
 const WEBRTC_DISABLE_NON_PROXY = 'disable_non_proxied_udp'
@@ -127,6 +128,7 @@ class Frame extends ImmutableComponent {
       this.webview.send(messages.BRAVERY_DEFAULTS_UPDATED, this.braveryDefaults)
     } else if (location === 'about:newtab') {
       this.webview.send(messages.NEWTAB_DATA_UPDATED, {
+        showEmptyPage: getSetting(settings.NEWTAB_MODE) === newTabMode.EMPTY_NEW_TAB,
         trackedBlockersCount: this.props.trackedBlockersCount,
         adblockCount: this.props.adblockCount,
         httpsUpgradedCount: this.props.httpsUpgradedCount,

js/lib/appUrlUtil.js

@@ -171,6 +171,7 @@ module.exports.newFrameUrl = function () {
       })
       return defaultSearchEngineSettings[0].base
 
+    case newTabMode.EMPTY_NEW_TAB:
     case newTabMode.NEW_TAB_PAGE:
     default:
       return 'about:newtab'