Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Refactor buttons on about:preferences#payments and bookmark dialog #5705

Merged
merged 2 commits into from
Nov 23, 2016
Merged

Refactor buttons on about:preferences#payments and bookmark dialog #5705

merged 2 commits into from
Nov 23, 2016

Commits on Nov 22, 2016

  1. Refactor buttons on about:preferences#payments

    Fixes #4786
    
    - Moved paddings and width in "whiteButton" to "wideButton"
    - Added "wideButton" to the advanced settings button on about:preferences#payments
    - Added font-size to the button
    - Added display:flex to footer of advanced settings
    - Added white-space:nowrap to "buttonCommon" (buttons will not be wrapped by default)
    
    Auditors: @jkup
    
    Test Plan:
    
    1. Open about:preferences#payments
    2. Make sure the font size of the two buttons "Add funds" and "Advanced Settings..." is equal
    3. Click "Advanced Settings..."
    4. Make sure the buttons on the footer are aligned center
    5. Make sure each button is not wrapped
    Suguru Hirahara committed Nov 22, 2016
    Configuration menu
    Copy the full SHA
    75a754a View commit details
    Browse the repository at this point in the history
  2. Refactor buttons on about:preferences#payments (part 2)

    - Removed redundant classes from bookmarkButtons to fix the size difference between "Remove" and "Done" buttons, which was introduced with the commit 85e428a
    - Introduced new classes "removeButton" and "doneButton" inside bookmarkButtons to make the width of the row same as the other rows
    - Introduced a new class "copyButton" to keep the font-size of the recovery key copy buttons to 14px
    - Indroduced a flexbox to copyKeyContainer to keep the buttons aligned
    
    Auditors: @bradleyrichter
    
    Test Plan:
    1. Click the bookmark button on the URL bar
    2. Make sure height of "Remove" and "Done" buttons is equal
    3. Make sure "Remove" button is longer than "Done" button
    4. Make sure color of "Remove" label is no longer white on hover
    5. Make sure width of the row of the buttons is equal to the other rows
    6. Open about:bookmarks and edit a bookmark
    7. Make sure height and width of "Remove" and "Done" are equal
    8. Open about:preferences#payments, click Advanced Settings and Backup your wallet
    9. Make sure keys and buttons are aligned
    10. Make sure font-size of the labels "Copy" is 14px
    Suguru Hirahara committed Nov 22, 2016
    1 Configuration menu
    Copy the full SHA
    23207ed View commit details
    Browse the repository at this point in the history